Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed version of types/chai to 4.3.0 #4033

Merged
merged 1 commit into from
Apr 14, 2022
Merged

fix: changed version of types/chai to 4.3.0 #4033

merged 1 commit into from
Apr 14, 2022

Conversation

jeffb-sfdc
Copy link
Contributor

What does this PR do?

  • pin @types/chai to 4.3.0 as 4.3.1 has introduced breaking changes

What issues does this PR fix or reference?

@W-10994021@

Functionality Before

Build is broken in main and multiple branches

Functionality After

Build is fixed

@jeffb-sfdc jeffb-sfdc requested a review from a team as a code owner April 14, 2022 00:55
@jeffb-sfdc jeffb-sfdc merged commit 812784a into main Apr 14, 2022
@jeffb-sfdc jeffb-sfdc deleted the jb/fix_types_chai_in_main branch April 14, 2022 01:25
@mohanraj-r mohanraj-r mentioned this pull request Apr 14, 2022
Closed
This was referenced Oct 6, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jag-j jag-j jag-j approved these changes

@randi274 randi274 Awaiting requested review from randi274 randi274 is a code owner automatically assigned from forcedotcom/ide-experience

@mohanraj-r mohanraj-r Awaiting requested review from mohanraj-r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffb-sfdc @jag-j