Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash on instanceURL #751

Closed
wants to merge 3 commits into from

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Nov 15, 2018

What does this PR do?

In Windows, we experience issues initializing the Apex Interactive Debugger because the url we build to connect to the Streaming API has an additional slash, making it an invalid url. The changes here strip the trailing slash of the host url.

What issues does this PR fix or reference?

#722, @W-5622038@

Copy link
Collaborator

@AnanyaJha AnanyaJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!!

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #751 into develop will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #751      +/-   ##
===========================================
- Coverage    74.23%   74.22%   -0.02%     
===========================================
  Files          163      163              
  Lines         6609     6610       +1     
  Branches      1039     1040       +1     
===========================================
  Hits          4906     4906              
  Misses        1433     1433              
- Partials       270      271       +1
Impacted Files Coverage Δ
...forcedx-apex-debugger/src/core/streamingService.ts 97.22% <50%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d177f4e...dff8951. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants