Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detecting whether a route is a pure layout route breaks in some cases, if the code only relies on the naming conventions. Probably it is more safe to inspect the
EntryRoute
properties and inspect parent routes of index routes as well.Fixes #17
Extract the logic to determine the route type in an extra file (as it is used twice - in active page tab and in the routes tab).
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Mainly just by using the
remix-app-for-testing
and verifying that everything still works as intended after adding more routes, that broke the original implementation.Checklist: