feat: cursor-based pagination for payments and tasks #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 19.41% 19.76% +0.35%
==========================================
Files 104 103 -1
Lines 4600 4674 +74
==========================================
+ Hits 893 924 +31
- Misses 3607 3646 +39
- Partials 100 104 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gfyrag
reviewed
Jan 5, 2023
internal/app/api/connector.go
Outdated
| HasMore: paginationDetails.HasMore, | ||
| Previous: paginationDetails.PreviousPage, | ||
| Next: paginationDetails.NextPage, | ||
| Data: nil, |
There was a problem hiding this comment.
When using cursor, data must be here.
gfyrag
reviewed
Jan 5, 2023
internal/app/api/connector.go
Outdated
| Data: &data, | ||
| Cursor: &sharedapi.Cursor[[]listTasksResponseElement]{ | ||
| PageSize: paginationDetails.PageSize, | ||
| Total: sharedapi.Total{ |
gfyrag
reviewed
Jan 5, 2023
swagger.yml
Outdated
| description: How many payments to skip, pagination can be achieved in conjunction with 'limit' parameter. | ||
| example: 100 | ||
| type: string | ||
| description: Cursor for pagination. |
There was a problem hiding this comment.
Can you please add details on how to use it?
For instance in the ledger I wrote this description:
"Parameter used in pagination requests. Maximum page size is set to 15. Set to the value of next for the next page of results. Set to the value of previous for the previous page of results. No other parameters can be set when the pagination token is set."
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com>
antoinegelloz
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Zawila 113581282+darkmatterpool@users.noreply.github.com