chore: Update swagger #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antoinegelloz
commented
Jan 9, 2023
•
antoinegelloz
commented
- fixed swagger mistakes
- changed swagger to have cleaner generated structs, better naming, more consistent with other services
- removed client generation
- make sure pre-commit has run
added 2 commits
January 9, 2023 09:46
Codecov Report
@@ Coverage Diff @@
## feat/switch-to-cursor-pagination #84 +/- ##
====================================================================
- Coverage 18.50% 18.39% -0.11%
====================================================================
Files 103 103
Lines 4674 4674
====================================================================
- Hits 865 860 -5
- Misses 3710 3714 +4
- Partials 99 100 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gfyrag
approved these changes
Jan 9, 2023
darkmatterpool
approved these changes
Jan 9, 2023
darkmatterpool
added a commit
that referenced
this pull request
Jan 11, 2023
* feat: cursor-based pagination for payments and tasks Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com> * fix: swagger definitions & accounts cursor support Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com> * fix: swagger cursor description Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com> * chore: Update swagger (#84) * feat: added pagination tests Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com> * fix: test cases Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com> Signed-off-by: Lawrence Zawila <113581282+darkmatterpool@users.noreply.github.com> Co-authored-by: Antoine Gelloz <antoine.gelloz@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.