fix #154 values for 0

[cwtuan]

No description provided.

[scriby]

Also fixes #88, #112, #119, #127, #136, #141, #144, and an untold number of future issues caused by developers making a perfectly reasonable assumption about the behavior of this library.

(The assumption I'm referring to is that if a developer has observed that all non-zero numbers get coerced to a string during string formatting, that zero would also get coerced to a string.)

[jasonmit]

@caridy any chance we can land this?

[cwtuan]

could anyone accept the PR?

[cwtuan]

@jasonmit Could I take the ownership too? I'm willing to maintain this project

[steida]

@ericf How we can help you with PR?

[okuryu]

Could you add tests for this?

[steida]

@okuryu Doing OSS 24/7 already :-/

[rlivsey]

@cwtuan feel free to pull in the tests I wrote for #112

[MaKleSoft]

How is this not merged after over two months? It's a straightforward fix for a very prominent problem! Can somebody please just hit that merge button?

[steida]

I always wonder what terrible had to happen in maintainers life that they even don't bother to answer or kill the project with some short explanation. And yet, I am open source maintainer too.

[steida]

I see, caridy@gmail.com doesn't work for Yahoo anymore.

[caridy]

This seems to be very straight forward, but probably a non-backward compatible change. I think we will have to wait for a Yahoo maintainer to chime in and release a new version of this with this change in. Unfortunately @ericf is not longer at Yahoo, and I don't know who is maintaining this anymore. I certainly can't do the release anymore, so my approve here means little :/

[steida]

I was chatting with former Yahoo developers, it seems nobody in Yahoo is interested in maintenance. We have to fork it probably.

[okuryu]

Last month I got commit bits of all repositories of FormatJS suite including intl-messageformat, so I definitely would like to cooperate with these maintenance.

[MaKleSoft]

Does this mean https://formatjs.io/ is dead?

[steida]

Probably is. It has all symptoms. Key people left the company, and the company doesn't care about open source at all.

[jasonmit]

I reverted the commit - did not see the discussion that took place since I last had the tab opened. I reopened with @rlivsey's tests added and took into account past comments by @ericf to guard against false.

#162

@okuryu @caridy can you merge and version a new major?