This repository has been archived by the owner on May 23, 2019. It is now read-only.
zero values should not return an empty string #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
CI failures unrelated - separate issue across all PRs now that needs to be addressed. |
caridy
approved these changes
Jul 3, 2017
okuryu
approved these changes
Jul 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88, #112, #119, #127, #136, #141, #144
This is based on the work of @cwtuan and @rlivsey - just merging the two PRs into one so we can finally get this merged and versioned. Since it's technically a breaking change, we'll need to bump the major.
@okuryu @caridy can you merge and version a new major?