Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ad-hoc resource validation on remove=true #101

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

fornellas
Copy link
Owner

@fornellas fornellas commented Aug 26, 2024

This code is redundant, as we had this logic moved to resources/resources.go:ValidateResource(), so it is universally applied to all resource types, no code duplication required.

commit-id:d1ea523e


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@fornellas fornellas enabled auto-merge (rebase) August 26, 2024 17:58
@fornellas fornellas mentioned this pull request Aug 26, 2024
@fornellas fornellas changed the base branch from master to spr/master/574d04a7 August 29, 2024 21:42
@fornellas fornellas changed the base branch from spr/master/574d04a7 to master September 1, 2024 10:44
@fornellas fornellas changed the base branch from master to spr/master/574d04a7 September 1, 2024 10:44
@fornellas fornellas changed the base branch from spr/master/574d04a7 to master September 1, 2024 15:10
@fornellas fornellas changed the base branch from master to spr/master/574d04a7 September 1, 2024 15:10
Base automatically changed from spr/master/574d04a7 to spr/master/b4b6383b September 1, 2024 15:11
fornellas added a commit that referenced this pull request Sep 1, 2024
PR #90 introduced sections and logs as info when a new section is
created. However, if the log level is higher (eg: warn), then the
section won't be logged, and any higher level log (eg: warn, error) will
be indented without a section.

This PR fixes that, by only enabling indentation when the level info is
enabled.

---

**Stack**:
- #107
- #108
- #111
- #110
- #109
- #106
- #105
- #104
- #103
- #102
- #101
- #112⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@fornellas fornellas changed the base branch from spr/master/b4b6383b to master September 1, 2024 15:15
@fornellas fornellas changed the base branch from master to spr/master/f7c2cc66 September 1, 2024 15:16
fornellas added a commit that referenced this pull request Sep 1, 2024
On #75 we dropped arm 32bit support (we'll decide on
#124 what to do about it).
There was left over references, which are [breaknig the
build](https://github.com/fornellas/resonance/actions/runs/10646571228):

```
The workflow is not valid. .github/workflows/push.yaml (Line: 57, Col: 9): Job 'release' depends on unknown job 'linux_arm'. .github/workflows/push.yaml (Line: 100, Col: 9): Job 'coveralls' depends on unknown job 'linux_arm'.
```

This PR fixes that, by erasing all arm 32 references.

---

**Stack**:
- #116
- #107
- #108
- #111
- #110
- #109
- #106
- #105
- #104
- #103
- #102
- #101
- #112
- #126
- #129⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@fornellas fornellas force-pushed the spr/master/d1ea523e branch 2 times, most recently from db38c8a to 0322c4a Compare September 1, 2024 21:50
fornellas added a commit that referenced this pull request Sep 1, 2024
Mostly just moving the test grpc agent from #75 to a place that matches
the HTTP agent placement.

Bonus:

- Call go build to both client & server, so we can actually easily bulid
& manually test them.
- Fix a bug with `RRB_IGNORE_PATTERN` not ignoring generated `.go`
files, so RRB would just re-trigger itself and never finish.

commit-id:b4b6383b

---

**Stack**:
- #116
- #107
- #108
- #111
- #110
- #109
- #106
- #105
- #104
- #103
- #102
- #101
- #130
- #126⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@fornellas fornellas force-pushed the spr/master/d1ea523e branch 2 times, most recently from 52327ab to b6b4ed0 Compare September 2, 2024 08:15
This code is redundant, as we had this logic moved to `resources/resources.go:ValidateResource()`, so it is universally applied to all resource types, no code duplication required.

commit-id:d1ea523e
Base automatically changed from spr/master/f7c2cc66 to master September 3, 2024 19:02
@fornellas fornellas merged commit e1a6625 into master Sep 3, 2024
15 checks passed
@fornellas fornellas deleted the spr/master/d1ea523e branch September 3, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants