Drop ad-hoc resource validation on remove=true #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2024
Merged
Merged
Merged
Merged
fornellas
force-pushed
the
spr/master/d1ea523e
branch
from
1c054ea
to
a8fc17f
Compare
This was referenced Aug 28, 2024
Merged
Merged
fornellas
force-pushed
the
spr/master/d1ea523e
branch
from
a8fc17f
to
2aba8ca
Compare
This was referenced Aug 29, 2024
Merged
fornellas
force-pushed
the
spr/master/d1ea523e
branch
from
2aba8ca
to
52381c1
Compare
fornellas
force-pushed
the
spr/master/d1ea523e
branch
from
52381c1
to
edcf6df
Compare
fornellas
force-pushed
the
spr/master/d1ea523e
branch
from
edcf6df
to
bb1f37d
Compare
fornellas
force-pushed
the
spr/master/d1ea523e
branch
from
bb1f37d
to
1c2b437
Compare
fornellas
added a commit
that referenced
this pull request
Sep 1, 2024
PR #90 introduced sections and logs as info when a new section is created. However, if the log level is higher (eg: warn), then the section won't be logged, and any higher level log (eg: warn, error) will be indented without a section. This PR fixes that, by only enabling indentation when the level info is enabled. --- **Stack**: - #107 - #108 - #111 - #110 - #109 - #106 - #105 - #104 - #103 - #102 - #101 - #112 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
fornellas
force-pushed
the
spr/master/b4b6383b
branch
from
0557d53
to
159ad1e
Compare
fornellas
force-pushed
the
spr/master/d1ea523e
branch
from
1c2b437
to
3391174
Compare
fornellas
added a commit
that referenced
this pull request
Sep 1, 2024
On #75 we dropped arm 32bit support (we'll decide on #124 what to do about it). There was left over references, which are [breaknig the build](https://github.com/fornellas/resonance/actions/runs/10646571228): ``` The workflow is not valid. .github/workflows/push.yaml (Line: 57, Col: 9): Job 'release' depends on unknown job 'linux_arm'. .github/workflows/push.yaml (Line: 100, Col: 9): Job 'coveralls' depends on unknown job 'linux_arm'. ``` This PR fixes that, by erasing all arm 32 references. --- **Stack**: - #116 - #107 - #108 - #111 - #110 - #109 - #106 - #105 - #104 - #103 - #102 - #101 - #112 - #126 - #129 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
gfechio
approved these changes
Sep 1, 2024
fornellas
force-pushed
the
spr/master/d1ea523e
branch
2 times, most recently
from
db38c8a
to
0322c4a
Compare
fornellas
added a commit
that referenced
this pull request
Sep 1, 2024
Mostly just moving the test grpc agent from #75 to a place that matches the HTTP agent placement. Bonus: - Call go build to both client & server, so we can actually easily bulid & manually test them. - Fix a bug with `RRB_IGNORE_PATTERN` not ignoring generated `.go` files, so RRB would just re-trigger itself and never finish. commit-id:b4b6383b --- **Stack**: - #116 - #107 - #108 - #111 - #110 - #109 - #106 - #105 - #104 - #103 - #102 - #101 - #130 - #126 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
fornellas
force-pushed
the
spr/master/d1ea523e
branch
2 times, most recently
from
52327ab
to
b6b4ed0
Compare
This code is redundant, as we had this logic moved to `resources/resources.go:ValidateResource()`, so it is universally applied to all resource types, no code duplication required. commit-id:d1ea523e
fornellas
force-pushed
the
spr/master/d1ea523e
branch
from
b6b4ed0
to
f02dd5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is redundant, as we had this logic moved to
resources/resources.go:ValidateResource(), so it is universally applied to all resource types, no code duplication required.commit-id:d1ea523e
Stack: