-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify id & remove resource fields #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2024
Merged
Merged
Merged
Merged
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
3 times, most recently
from
August 28, 2024 15:03
d5111a1
to
2639a66
Compare
Merged
Merged
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
from
August 29, 2024 21:42
2639a66
to
616c997
Compare
Merged
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
from
August 31, 2024 16:42
616c997
to
19be697
Compare
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
from
September 1, 2024 14:29
a338704
to
3ad0a62
Compare
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
from
September 1, 2024 15:10
3ad0a62
to
9f09409
Compare
fornellas
added a commit
that referenced
this pull request
Sep 1, 2024
PR #90 introduced sections and logs as info when a new section is created. However, if the log level is higher (eg: warn), then the section won't be logged, and any higher level log (eg: warn, error) will be indented without a section. This PR fixes that, by only enabling indentation when the level info is enabled. --- **Stack**: - #107 - #108 - #111 - #110 - #109 - #106 - #105 - #104 - #103 - #102 - #101 - #112 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
from
September 1, 2024 15:16
9f09409
to
710b4d0
Compare
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
2 times, most recently
from
September 1, 2024 18:01
50cb5ee
to
1e1f5f2
Compare
fornellas
force-pushed
the
spr/master/4d62c05f
branch
from
September 1, 2024 18:01
4624a93
to
9662934
Compare
fornellas
added a commit
that referenced
this pull request
Sep 1, 2024
On #75 we dropped arm 32bit support (we'll decide on #124 what to do about it). There was left over references, which are [breaknig the build](https://github.com/fornellas/resonance/actions/runs/10646571228): ``` The workflow is not valid. .github/workflows/push.yaml (Line: 57, Col: 9): Job 'release' depends on unknown job 'linux_arm'. .github/workflows/push.yaml (Line: 100, Col: 9): Job 'coveralls' depends on unknown job 'linux_arm'. ``` This PR fixes that, by erasing all arm 32 references. --- **Stack**: - #116 - #107 - #108 - #111 - #110 - #109 - #106 - #105 - #104 - #103 - #102 - #101 - #112 - #126 - #129 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
from
September 1, 2024 18:27
1e1f5f2
to
b6b5c33
Compare
gfechio
approved these changes
Sep 1, 2024
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
from
September 1, 2024 21:50
b6b5c33
to
da334b4
Compare
fornellas
added a commit
that referenced
this pull request
Sep 1, 2024
Mostly just moving the test grpc agent from #75 to a place that matches the HTTP agent placement. Bonus: - Call go build to both client & server, so we can actually easily bulid & manually test them. - Fix a bug with `RRB_IGNORE_PATTERN` not ignoring generated `.go` files, so RRB would just re-trigger itself and never finish. commit-id:b4b6383b --- **Stack**: - #116 - #107 - #108 - #111 - #110 - #109 - #106 - #105 - #104 - #103 - #102 - #101 - #130 - #126 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
5 times, most recently
from
September 3, 2024 22:47
eedb846
to
31dc195
Compare
fornellas
force-pushed
the
spr/master/4d62c05f
branch
from
September 3, 2024 22:47
07a674c
to
22d811e
Compare
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
from
September 3, 2024 22:47
31dc195
to
8c1f731
Compare
All resource types must have both an "id" field, that uniquely identifies the resource at a host, and a "remove" field, to inform whether it should be... removed. As of now, both fields are mandatory, but they can live anywhere in the struct, and the Id field, requires a special tag. This PR simplifies that, enforcing instead that all resources have the first 2 fields as such: ```go type Foo struct { FooName string `yaml:"foo_name"` Remove bool `yaml:"remove,omitempty"` } ``` which simplifies things quite a bit. In particular, when marshaling yamls, the id field will be guaranteed to be the first one, which eases understanding. commit-id:aa4f43b2
fornellas
force-pushed
the
spr/master/aa4f43b2
branch
from
September 3, 2024 22:48
8c1f731
to
a070c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All resource types must have both an "id" field, that uniquely identifies the resource at a host, and a "remove" field, to inform whether it should be... removed.
As of now, both fields are mandatory, but they can live anywhere in the struct, and the Id field, requires a special tag.
This PR simplifies that, enforcing instead that all resources have the first 2 fields as such:
which simplifies things quite a bit.
In particular, when marshaling yamls, the id field will be guaranteed to be the first one, which eases understanding.
Stack: