Async usercall interface for SGX enclaves #291

mzohreva · 2020-10-02T18:40:16Z

No description provided.

mzohreva · 2020-10-02T19:01:42Z

MIO 0.7 port to SGX using this interface: https://github.com/mzohreva/mio/tree/mz/sgx-port-0.7

async-usercalls/src/lib.rs

async-usercalls/src/hacks/unsafe_typecasts.rs

async-usercalls/src/alloc/mod.rs

async-usercalls/src/lib.rs

async-usercalls/src/provider_core.rs

jethrogb · 2020-10-14T14:09:33Z

async-usercalls/src/duplicated.rs

@@ -0,0 +1,168 @@
+//! this file contains code duplicated from libstd's sys/sgx


Can you think of a logical division of the code in this PR between std and an external crate that reduces duplication?

I think these parts can live in std:

Most of the allocator (except io_bufs.rs)

callback.rs which is the main user of the duplicated code

…ulacrum Add Metadata in std::os::fortanix_sgx::io::FromRawFd Needed for fortanix/rust-sgx#291 cc `@jethrogb`

…acrum Add Metadata in std::os::fortanix_sgx::io::FromRawFd Needed for fortanix/rust-sgx#291 cc `@jethrogb`

async-usercalls/Cargo.toml

async-usercalls/src/batch_drop.rs

async-usercalls/src/callback.rs

jethrogb · 2020-11-27T13:26:50Z

async-usercalls/src/io_bufs.rs

+                ref range,
+            } => &mut user[range.start..range.end],
+            UserBufKind::Shared { ref user, ref range } => {
+                let user = unsafe { &mut *user.get() };


Why is this safe? Aren't there multiple references to this UnsafeCell?

There is exactly one way to construct this variant of UserBufKind and that's through WriteBuffer::consumable_chunk() which ensures there is at most 1 instance of this at a time. The other reference is inside the WriteBuffer which will not access the range specified here.

jethrogb · 2020-11-27T13:29:22Z

async-usercalls/src/io_bufs.rs

+/// running in the enclave while a portion of it can be passed to a `write`
+/// usercall running concurrently. It ensures that enclave code does not write
+/// to the portion sent to userspace.
+pub struct WriteBuffer {


Where/how is this used?

It's used in my MIO implementation.

async-usercalls/rustfmt.toml

async-usercalls/src/lib.rs

async-usercalls/src/queues.rs

async-usercalls/src/tests.rs

async-usercalls/src/io_bufs.rs

raoulstrackx · 2021-02-04T08:32:54Z

The PR looks good to me. When the other conversations have been resolved, I'll accept.

mzohreva · 2021-07-20T19:49:08Z

I've cherry-picked the commit in #336 to unblock a compiler update. Will need to create a branch preserving this history before rebase/merge.

kaimast · 2021-10-03T06:34:59Z

I'm curious why this branch has not been merged. Did async support already land some other way?

dingxiangfei2009 · 2021-10-12T05:58:28Z

@kaimast Not really there yet. I think async IO is inaccessible so far. I don't think they are going to pursue full async support anymore.

alexanderheuts · 2021-10-12T11:25:52Z

We are still planning to add async support. I have no concrete timeline yet.

`UsercallEvent::Start` was being sent in `fn handle_usercall`, which is too late. It needs to be sent before we receive the next usercall from the enclave so we can maintain the invariant that "we only need to keep track of cancels received before the actual usercall if the read position has not moved past the write position when cancel was received."

393: [PLAT-896] Verify fifo descriptor pointers r=jethrogb a=raoulstrackx Some checks are missing when allocating and processing `FifoDescriptor` Co-authored-by: Raoul Strackx <raoul.strackx@fortanix.com>

398: [PLAT-838] Refactor `ipc_queue` backport r=jethrogb a=raoulstrackx Backports #396 Co-authored-by: Raoul Strackx <raoul.strackx@fortanix.com>

400: Rust nightly compatibility r=jethrogb a=raoulstrackx The `mz/async-usercalls` is a rather old branch that hasn't been kept up to date with the latest Rust nightly compilers. This PR corrects this situation by backporting many of the changes already on master. Co-authored-by: Raoul Strackx <raoul.strackx@fortanix.com>

…n issue #433

432: Enable `enclave_loader()` fallback to libsgx_enclave_common.so.1 r=Taowyoo a=raoulstrackx The `aesmd` service depends on a `dcap_quoteprov.so` library (the DCAP provider) to aid in DCAP attestations. For it to work correctly, it may need to (recursively) request a DCAP attestation itself. For that a `dcap-ql::enclave_loader` call is required. Unfortunately, when this happens as part of the `aesmd` service, `Dl::this()` returns `/opt/intel/sgx-aesm-service/aesm/aesm_service`. This leads to an error as the expected symbols can't be located. This PR adds a fallback to the `libsgx_enclave_common.so.1` library (or `sgx_enclave_common.dll` on windows). Co-authored-by: Raoul Strackx <raoul.strackx@fortanix.com> Co-authored-by: Yuxiang Cao <yuxiang.cao@fortanix.com>

Taowyoo · 2024-04-13T00:18:06Z

Close this since this is done by #515

mzohreva requested a review from jethrogb October 2, 2020 18:40

mzohreva force-pushed the mz/async-usercalls branch from 7356b0f to c05aae4 Compare October 5, 2020 20:20

mzohreva requested a review from jseyfried October 6, 2020 17:14

jethrogb reviewed Oct 14, 2020

View reviewed changes

mzohreva force-pushed the mz/cancel_queue branch from c37d9ac to 95b558e Compare October 21, 2020 22:04

mzohreva force-pushed the mz/async-usercalls branch from f4a9544 to 34340f5 Compare October 21, 2020 22:55

mzohreva force-pushed the mz/cancel_queue branch from 95b558e to 57b0325 Compare November 4, 2020 19:48

mzohreva force-pushed the mz/async-usercalls branch from 34340f5 to e7d7cd9 Compare November 4, 2020 20:11

jethrogb mentioned this pull request Nov 5, 2020

Implement asynchronous usercalls #96

Open

4 tasks

mzohreva force-pushed the mz/cancel_queue branch from e741386 to 2639806 Compare November 10, 2020 18:39

mzohreva force-pushed the mz/async-usercalls branch from e7d7cd9 to 77ab85a Compare November 10, 2020 18:42

mzohreva mentioned this pull request Nov 11, 2020

Add Metadata in std::os::fortanix_sgx::io::FromRawFd rust-lang/rust#78953

Merged

mzohreva force-pushed the mz/async-usercalls branch 2 times, most recently from 6d52998 to e381dca Compare November 21, 2020 02:24

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 24, 2020

Rollup merge of rust-lang#78953 - mzohreva:mz/from_raw_fd, r=Mark-Sim…

04db18d

…ulacrum Add Metadata in std::os::fortanix_sgx::io::FromRawFd Needed for fortanix/rust-sgx#291 cc `@jethrogb`

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2020

Auto merge of rust-lang#78953 - mzohreva:mz/from_raw_fd, r=Mark-Simul…

4167d73

…acrum Add Metadata in std::os::fortanix_sgx::io::FromRawFd Needed for fortanix/rust-sgx#291 cc `@jethrogb`

jethrogb reviewed Nov 27, 2020

View reviewed changes

raoulstrackx reviewed Jan 27, 2021

View reviewed changes

mzohreva force-pushed the mz/async-usercalls branch from 7ae56e2 to 06f6667 Compare January 27, 2021 23:35

mzohreva force-pushed the mz/cancel_queue branch from 2639806 to 4908696 Compare February 26, 2021 22:44

mzohreva added 8 commits February 26, 2021 14:49

Async usercall interface for SGX enclaves

9a9b2a0

Poll based interface

373a2d2

Poll through separate type

a75e589

Simplify CancelHandle

95ec8ae

Move io_bufs out of alloc module

c650f46

Remove allocator module for now

b6a2437

Remove reserved field

c038129

Add CallbackHandlerWaker

6eb6a34

mzohreva added 2 commits February 26, 2021 14:49

Minor fixes

7668388

Reorganize tests, address review comments

de6b5f3

mzohreva force-pushed the mz/async-usercalls branch from 06f6667 to de6b5f3 Compare February 26, 2021 22:56

mzohreva and others added 3 commits February 26, 2021 17:15

Use invoke_with_usercalls macro to define Callback enum

f5f2199

Reduce batch size in CallbackHandler

6e5617e

Avoiding use of LLVM reserved register rbx

4cf2a8e

mzohreva and others added 10 commits October 18, 2021 18:37

Verify allocation FifoDescriptor

e1e92d3

Verify offset fifo queuer

d106b45

Revert to older toolchain

54c4623

Merge #393

d7632ef

393: [PLAT-896] Verify fifo descriptor pointers r=jethrogb a=raoulstrackx Some checks are missing when allocating and processing `FifoDescriptor` Co-authored-by: Raoul Strackx <raoul.strackx@fortanix.com>

Refactor ipc_queue to access userspace through a trait

b730db0

Making read_epoch AtomicU64

8117cb3

Merge #398

0837fce

398: [PLAT-838] Refactor `ipc_queue` backport r=jethrogb a=raoulstrackx Backports #396 Co-authored-by: Raoul Strackx <raoul.strackx@fortanix.com>

Rust nightly compatibility

1008a62

mzohreva mentioned this pull request Jul 28, 2022

Cancel queue + async usercall interface #404

Closed

raoulstrackx and others added 3 commits February 3, 2023 09:50

Enable enclave_loader() fallback to libsgx_enclave_common.so.1

367d286

ci: pin rust version to nightly-2023-01-31 to avoid error mentioned i…

c10e404

…n issue #433

Taowyoo closed this Apr 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Async usercall interface for SGX enclaves #291

Async usercall interface for SGX enclaves #291

mzohreva commented Oct 2, 2020

mzohreva commented Oct 2, 2020

jethrogb Oct 14, 2020

mzohreva Oct 14, 2020

jethrogb Nov 27, 2020

mzohreva Dec 2, 2020

jethrogb Nov 27, 2020

mzohreva Dec 2, 2020

raoulstrackx commented Feb 4, 2021

mzohreva commented Jul 20, 2021

kaimast commented Oct 3, 2021

dingxiangfei2009 commented Oct 12, 2021 •

edited

Loading

alexanderheuts commented Oct 12, 2021

Taowyoo commented Apr 13, 2024

		@@ -0,0 +1,168 @@
		//! this file contains code duplicated from libstd's sys/sgx

Async usercall interface for SGX enclaves #291

Async usercall interface for SGX enclaves #291

Conversation

mzohreva commented Oct 2, 2020

mzohreva commented Oct 2, 2020

jethrogb Oct 14, 2020

Choose a reason for hiding this comment

mzohreva Oct 14, 2020

Choose a reason for hiding this comment

jethrogb Nov 27, 2020

Choose a reason for hiding this comment

mzohreva Dec 2, 2020

Choose a reason for hiding this comment

jethrogb Nov 27, 2020

Choose a reason for hiding this comment

mzohreva Dec 2, 2020

Choose a reason for hiding this comment

raoulstrackx commented Feb 4, 2021

mzohreva commented Jul 20, 2021

kaimast commented Oct 3, 2021

dingxiangfei2009 commented Oct 12, 2021 • edited Loading

alexanderheuts commented Oct 12, 2021

Taowyoo commented Apr 13, 2024

dingxiangfei2009 commented Oct 12, 2021 •

edited

Loading