Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : improving arrangement of button in table #3579

Merged
merged 3 commits into from
Nov 3, 2019
Merged

fix : improving arrangement of button in table #3579

merged 3 commits into from
Nov 3, 2019

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Oct 29, 2019 •
edited
Loading

Fixes #3578

In mobile view buttons were going out of tabel so fixed them .

Changes proposed in this pull request:

  • Changing view of button vertical for mobile view and horizontal for desktop.
    Screenshot from 2019-10-27 19-06-40
    Screenshot from 2019-10-27 19-06-25

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

kushthedude
kushthedude previously approved these changes Oct 30, 2019
View reviewed changes
@abhinavk96 abhinavk96 merged commit 9ae3414 into fossasia:development Nov 3, 2019
abhinavk96
abhinavk96 suggested changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just keep it vertical for all kinds of screens, eventually, if the number of speakers is more, the height will be wasted anyway on larger screens.

@maze-runnar maze-runnar deleted the patch-4 branch January 12, 2020 11:14
@maze-runnar maze-runnar mentioned this pull request Feb 18, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@mariobehling mariobehling Awaiting requested review from mariobehling

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

@uds5501 uds5501 Awaiting requested review from uds5501

@kushthedude kushthedude Awaiting requested review from kushthedude

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improving arrangements of button in table
3 participants
@maze-runnar @abhinavk96 @kushthedude