Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase table width to avoid overflow and collapse #4114

Merged
merged 2 commits into from
Feb 20, 2020
Merged

fix: increase table width to avoid overflow and collapse #4114

merged 2 commits into from
Feb 20, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #4113
Screenshot from 2020-02-18 00-34-30

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Feb 17, 2020
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #4114 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           development   #4114   +/-   ##
===========================================
  Coverage         21.8%   21.8%           
===========================================
  Files              451     451           
  Lines             4729    4729           
===========================================
  Hits              1031    1031           
  Misses            3698    3698

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359ff53...cd67d48. Read the comment docs.

@maze-runnar
Copy link
Contributor Author

before :
Screenshot from 2020-02-18 00-51-49
After :
Screenshot from 2020-02-18 00-54-39

@kushthedude
Copy link
Member

kushthedude commented Feb 17, 2020

Increase the column width rather than this and also increase widths for URL sections as I can see overlaps

@maze-runnar
Copy link
Contributor Author

maze-runnar commented Feb 17, 2020

Increase the column width rather than this and also increase widths for URL sections too as I can see overlaps

How to increase width in ember-tables? And also change in tables/default will cause change in evry page that uses ember table.

@kushthedude
Copy link
Member

kushthedude commented Feb 17, 2020 via email

@maze-runnar
Copy link
Contributor Author

There will be multiple old PRs for similar sort of issue. Just make a search and you will get your answer.

#3579 (review)

@kushthedude
Copy link
Member

kushthedude commented Feb 18, 2020 via email

@mohitm15
Copy link
Contributor

@Maze-runner Refer #2871

@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-02-18 12-18-05
Screenshot from 2020-02-18 12-21-51
Screenshot from 2020-02-18 12-21-54

@maze-runnar
Copy link
Contributor Author

@Maze-runner Refer #2871

that's not the solution, that is root of this issue.

@snitin315
Copy link
Member

Screenshot_2020-02-18-15-30-04-489_com android chrome

Overlapping for name email and phone field as well.

@kushthedude
Copy link
Member

@Maze-runner Refer #2871

that's not the solution, that is root of this issue.

@maze-runnar For the speaker section, Please the sessions table and implement it similarly with actions buttons beneath the name. Regarding the access code tables, just increase the column width so that values do not overlap.

@maze-runnar
Copy link
Contributor Author

Screenshot_2020-02-18-15-30-04-489_com android chrome

Overlapping for name email and phone field as well.

@snitin315 can you please specify its path.

@snitin315
Copy link
Member

snitin315 commented Feb 18, 2020 via email

@maze-runnar
Copy link
Contributor Author

@Maze-runner Refer #2871

that's not the solution, that is root of this issue.

@maze-runnar For the speaker section, Please the sessions table and implement it similarly with actions buttons beneath the name.

I'm not getting this line, can you please tell what to do exactly?

@kushthedude
Copy link
Member

@Maze-runner Refer #2871

that's not the solution, that is root of this issue.

@maze-runnar For the speaker section, Please the sessions table and implement it similarly with actions buttons beneath the name.

I'm not getting this line, can you please tell what to do exactly?

Just increase the widths for now then.

@maze-runnar
Copy link
Contributor Author

Just increase the widths for now then.

Done !

@maze-runnar maze-runnar changed the title fix: make button verticle for mobile view to avoid overflow fix: increase table width to avoid overflow and collapse Feb 19, 2020
@maze-runnar
Copy link
Contributor Author

@kushthedude please review

@snitin315
Copy link
Member

When you make very minor changes to a PR of yours (like for example fixing a failing Travis build or some small style corrections or minor changes requested by reviewers) make sure you squash your commits afterward so that you don't have an absurd number of commits for a very small fix.

Update cell-actions.hbs

Update list.js

adding width to table columns

Update cell-buttons.hbs

Update cell-actions.hbs

Update list.js

updating width of the table

incresing table width to avoid url collapsing
@kushthedude kushthedude merged commit b835152 into fossasia:development Feb 20, 2020
@maze-runnar maze-runnar deleted the patch-18 branch February 20, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

horizontal buttons are overflowing in mobile-view
4 participants