-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase table width to avoid overflow and collapse #4114
Conversation
Codecov Report
@@ Coverage Diff @@
## development #4114 +/- ##
===========================================
Coverage 21.8% 21.8%
===========================================
Files 451 451
Lines 4729 4729
===========================================
Hits 1031 1031
Misses 3698 3698 Continue to review full report at Codecov.
|
Increase the column width rather than this and also increase widths for URL sections as I can see overlaps |
How to increase width in ember-tables? And also change in tables/default will cause change in evry page that uses ember table. |
There will be multiple old PRs for similar sort of issue. Just make a
search and you will get your answer.
…On Tue, 18 Feb, 2020, 01:24 Sundaram Dubey, ***@***.***> wrote:
Increase the column width rather than this and also increase widths for
URL sections too as I can see overlaps
How to increase width in ember-tables?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4114?email_source=notifications&email_token=AKQMTLRWBVCOAWKFRHX2PFTRDLTP7A5CNFSM4KWXBQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL7QE6A#issuecomment-587137656>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLTTOLG57VWCC4ESBD3RDLTP7ANCNFSM4KWXBQMA>
.
|
|
Increase the width for now , actions column is ultimately going to be
removed if number of properties increaaes.
…On Tue, 18 Feb, 2020, 11:07 Sundaram Dubey, ***@***.***> wrote:
There will be multiple old PRs for similar sort of issue. Just make a
search and you will get your answer.
#3579 (review)
<#3579 (review)>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4114?email_source=notifications&email_token=AKQMTLRWDCRL6IL2YHD4QATRDNXZ7A5CNFSM4KWXBQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMAUXEQ#issuecomment-587287442>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLT65QZEVTRHMY34RX3RDNXZ7ANCNFSM4KWXBQMA>
.
|
@Maze-runner Refer #2871 |
that's not the solution, that is root of this issue. |
@maze-runnar For the speaker section, Please the sessions table and implement it similarly with actions buttons beneath the name. Regarding the access code tables, just increase the column width so that values do not overlap. |
@snitin315 can you please specify its path. |
Speakers table.
…On Tue, 18 Feb 2020, 7:12 pm Sundaram Dubey, ***@***.***> wrote:
[image: Screenshot_2020-02-18-15-30-04-489_com android chrome]
<https://user-images.githubusercontent.com/46647141/74725357-c7782080-5263-11ea-82bc-9e4f3a9f4ffe.jpg>
Overlapping for name email and phone field as well.
@snitin315 <https://github.com/snitin315> can you please specify its path.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4114?email_source=notifications&email_token=ALD4OZNEX3R7PTRBPG3G6UTRDPQU7A5CNFSM4KWXBQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMCAI7A#issuecomment-587465852>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALD4OZOH5AXOXVVM5GDJSQLRDPQU7ANCNFSM4KWXBQMA>
.
|
I'm not getting this line, can you please tell what to do exactly? |
Just increase the widths for now then. |
Done ! |
@kushthedude please review |
|
Update cell-actions.hbs Update list.js adding width to table columns Update cell-buttons.hbs Update cell-actions.hbs Update list.js updating width of the table incresing table width to avoid url collapsing
Fixes #4113
Checklist
development
branch.