fix: Added required in TaxId in Billing Info

[Dishebh]

Fixes #4030

Short description of what this resolves:

Tax Id or Business Id field now marked as *.

Changes proposed in this pull request:

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• [] I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/jtdgp7a5k
✅ Preview: https://open-event-frontend-git-fork-dishebh-patch-1.eventyay.now.sh

[snitin315]

Please See the issue image again, Its actully the billing info part of order-form ,

open-event-frontend/app/templates/components/forms/orders/order-form.hbs

[codecov]

Codecov Report

Merging #4233 into development will decrease coverage by <.01%.
The diff coverage is 16.37%.

@@               Coverage Diff               @@
##           development    #4233      +/-   ##
===============================================
- Coverage        21.88%   21.87%   -0.01%     
===============================================
  Files              461      461              
  Lines             4830     4831       +1     
  Branches             5        5              
===============================================
  Hits              1057     1057              
- Misses            3771     3772       +1     
  Partials             2        2

Impacted Files	Coverage Δ
...p/components/events/view/export/download-common.js	10.34% <ø> (ø)	⬆️
.../controllers/events/view/edit/sessions-speakers.js	0% <ø> (ø)	⬆️
app/controllers/events/view/export.js	0% <ø> (ø)	⬆️
app/controllers/events/view/tickets/orders.js	0% <ø> (ø)	⬆️
app/components/widgets/forms/link-input.js	23.07% <ø> (ø)	⬆️
app/controllers/events/view/tickets/attendees.js	0% <ø> (ø)	⬆️
app/routes/events/view/sessions/edit.js	0% <ø> (ø)	⬆️
app/routes/events/view/sessions/create.js	0% <ø> (ø)	⬆️
app/components/public/call-for-speakers.js	0% <0%> (ø)	⬆️
...mponents/forms/events/view/create-discount-code.js	0% <0%> (ø)	⬆️
... and 93 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b93ac...2c075c8. Read the comment docs.

[Dishebh]

Please See the issue image again, Its actully the billing info part of order-form ,

open-event-frontend/app/templates/components/forms/orders/order-form.hbs

Yes, the Billing info part of order form refers to the widgets/forms/billing-info.

{{#if isBillingInfoNeeded}} {{widgets/forms/billing-info data=data event=event}} {{/if}}

[snitin315]

I'm not sure, please provide a full-page screenshot of your change.

[Dishebh]

I'm not sure, please provide a full-page screenshot of your change.

[snitin315]

Add Front-end check for company field as well.

[Dishebh]

Add Front-end check for company field as well.

I'm not sure why the front-end check is not working, since we are already using the required class in the Company label section as well.
For now, the pr only solves a part of the issue mentioned above.

[snitin315]

Please try to solve the complete issue.

[kushthedude]

Incomplete

[Dishebh]

Incomplete

This only solves a part of the issue. I am not sure why the check for the Company label is not working. That's why, cannot proceed further in solving the complete issue, for now that is.

[Dishebh]

What to do about this, then?

[Dishebh]

Solved the issue. Pls review @snitin315

[snitin315]

Tested, Works well.

[kushthedude]

Fix build

[kushthedude]

Fix lint and squash commits

[Dishebh]

Messed up my branch. Sorry, will close it and open a new one with required changes. Thanks

[snitin315]

git fetch upstream development
git reset --hard upstream/development