Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup pre-commit #4289

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

snitin315
Copy link
Member

Motivation #4233

@auto-label auto-label bot added the chore label Mar 29, 2020
@vercel
Copy link

vercel bot commented Mar 29, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/16ydgkmua
✅ Preview: https://open-event-frontend-git-fork-snitin315-development.eventyay.now.sh

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #4289 into development will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4289   +/-   ##
============================================
  Coverage        21.87%   21.87%           
============================================
  Files              461      461           
  Lines             4831     4831           
  Branches             5        5           
============================================
  Hits              1057     1057           
  Misses            3772     3772           
  Partials             2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953d3a7...f277535. Read the comment docs.

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal
Copy link
Member

Why?

@kushthedude
Copy link
Member

Why?

A single package can do the work of two combined over here.

@snitin315 snitin315 changed the title chore: setup lint-staged and husky chore: setup pre-commit Mar 31, 2020
@snitin315
Copy link
Member Author

@kushthedude Done 👍

@kushthedude kushthedude merged commit 4bbe50b into fossasia:development Mar 31, 2020
@kushthedude
Copy link
Member

kushthedude commented Mar 31, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants