feat: Adding a step two in wizard form #4905

maze-runnar · 2020-08-28T15:42:52Z

Short description of what this resolves:

Adding a new step in wizard

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-08-28T15:42:56Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/rlpc2ityt
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-6.eventyay.vercel.app

lgtm-com · 2020-08-28T15:47:27Z

This pull request introduces 3 alerts when merging f65366c into 3d0b2df - view on LGTM.com

new alerts:

3 for Unused variable, import, function or class

iamareebjamal · 2020-08-28T16:30:44Z

Shouldn't there be code deletion from basic details step JS?

codecov · 2020-08-28T16:32:16Z

Codecov Report

Merging #4905 into development will decrease coverage by 0.30%.
The diff coverage is 2.70%.

@@               Coverage Diff               @@
##           development    #4905      +/-   ##
===============================================
- Coverage        23.17%   22.86%   -0.31%     
===============================================
  Files              481      483       +2     
  Lines             5096     5121      +25     
  Branches            18       18              
===============================================
- Hits              1181     1171      -10     
- Misses            3911     3946      +35     
  Partials             4        4

Impacted Files	Coverage Δ
app/components/forms/wizard/basic-details-step.js	`18.57% <ø> (-5.82%)`	⬇️
app/components/forms/wizard/other-details-step.js	`0.00% <0.00%> (ø)`
app/controllers/events/view/edit/attendee.js	`0.00% <ø> (ø)`
app/controllers/events/view/edit/basic-details.js	`0.00% <ø> (ø)`
app/controllers/events/view/edit/other-details.js	`0.00% <0.00%> (ø)`
app/mixins/event-wizard.js	`1.13% <ø> (ø)`
app/router.js	`100.00% <100.00%> (ø)`
app/utils/computed-helpers.js	`22.50% <0.00%> (-7.50%)`	⬇️
app/components/widgets/forms/link-input.js	`42.10% <0.00%> (-5.27%)`	⬇️
app/helpers/ui-grid-number.js	`34.78% <0.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1474c3...7d45a6a. Read the comment docs.

maze-runnar · 2020-08-28T16:32:32Z

Shouldn't there be code deletion from basic details step JS?

yes, I would do that.

iamareebjamal · 2020-08-28T17:13:14Z

app/components/forms/wizard/basic-details-step.js

-  }),
+  // licenses: computed(function() {
+  //   return orderBy(licenses, 'name');
+  // }),


Please delete, don't comment

lgtm-com · 2020-08-28T17:15:29Z

This pull request introduces 2 alerts when merging d84211e into 6c6d9e4 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2020-08-28T17:24:13Z

This pull request introduces 9 alerts when merging 322150a into 6c6d9e4 - view on LGTM.com

new alerts:

8 for Unused variable, import, function or class
1 for Duplicate property

iamareebjamal · 2020-08-29T06:29:10Z

It seems that validation rules are just copied from basic details to other step. Please remove unneeded code from both steps. I wanted to merge this before including work on online event form because then it'll need to be updated again but going ahead with online form with old UI for now

maze-runnar · 2020-08-29T11:05:55Z

It seems that validation rules are just copied from basic details to other step. Please remove unneeded code from both steps. I wanted to merge this before including work on online event form because then it'll need to be updated again but going ahead with online form with old UI for now

@iamareebjamal I have cleared the validations and included only required validations now.

niranjan94 · 2020-08-29T11:06:40Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

Complexity increasing per file
==============================
- app/components/forms/wizard/other-details-step.js  4

See the complete overview on Codacy

niranjan94 · 2020-08-29T11:06:40Z

app/components/forms/wizard/other-details-step.js

+        licenceUrl : license.link
+      });
+    },
+     saveDraft() {


Codacy found an issue: Expected indentation of 4 spaces but found 5.

niranjan94 · 2020-08-29T11:06:41Z

app/components/forms/wizard/other-details-step.js

+              prompt : this.l10n.t('Please enter a valid url')
+            }
+          ]
+        },


Codacy found an issue: Unexpected trailing comma.

mariobehling · 2020-09-02T02:24:53Z

Works perfectly. Thanks!

I added an issue to add this step to the dashboard as well here #4936

mariobehling · 2020-09-02T09:42:57Z

@maze-runnar Please make a small change. I think it is too small to open an issue for that. So, I am just posting it here.

Change "Extra Details".. to "Extra details".. in the wizard top button, please.

snitin315 · 2020-09-02T14:25:38Z

@maze-runnar Please make a small change. I think it is too small to open an issue for that. So, I am just posting it here.

Change "Extra Details".. to "Extra details".. in the wizard top button, please.

Just created a follow-up PR. #4941

vercel bot deployed to Preview August 28, 2020 15:42 View deployment

auto-label bot added the feature label Aug 28, 2020

maze-runnar changed the title ~~feat: Add a step two with the heading "Additional Info and Settings"~~ feat: Adding a step two in wizard form Aug 28, 2020

vercel bot deployed to Preview August 28, 2020 15:55 View deployment

vercel bot deployed to Preview August 28, 2020 16:12 View deployment

vercel bot deployed to Preview August 28, 2020 16:15 View deployment

vercel bot deployed to Preview August 28, 2020 17:07 View deployment

iamareebjamal reviewed Aug 28, 2020

View reviewed changes

vercel bot deployed to Preview August 28, 2020 17:15 View deployment

vercel bot deployed to Preview August 28, 2020 17:19 View deployment

maze-runnar added 13 commits August 29, 2020 11:45

moving code of conduct, license, copyright to next step

5eb892b

create second step component

928d681

Create other-details-step.js

9c96cd8

Create other-details.hbs

f4ae897

Create other-details.js

e00711a

changing previous button route

844ee8c

changinf forward button route

03f8d14

adding Additional Info and Settings step to wizard

05310ba

adding other-details to route

4200db2

Update other-details.js

40efc22

Update other-details-step.js

c6e1cd5

Update other-details-step.js

c624180

Update other-details.js

b936781

maze-runnar and others added 4 commits August 29, 2020 11:45

deleting code that is moved to next page

08117ef

Update basic-details-step.js

12dcd6e

Update other-details-step.js

33bb1cf

fix build

6cd91c2

vercel bot deployed to Preview August 29, 2020 06:31 View deployment

removing validations that are not imp here

211c7a0

vercel bot deployed to Preview August 29, 2020 11:04 View deployment

niranjan94 reviewed Aug 29, 2020

View reviewed changes

fix

7d45a6a

iamareebjamal previously approved these changes Sep 1, 2020

View reviewed changes

iamareebjamal dismissed their stale review via 7d45a6a September 1, 2020 14:24

vercel bot deployed to Preview September 1, 2020 14:24 View deployment

iamareebjamal merged commit fcce5db into fossasia:development Sep 1, 2020

snitin315 mentioned this pull request Sep 2, 2020

fix: addition info step description #4941

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Adding a step two in wizard form #4905

feat: Adding a step two in wizard form #4905

maze-runnar commented Aug 28, 2020

vercel bot commented Aug 28, 2020 •

edited

Loading

lgtm-com bot commented Aug 28, 2020

iamareebjamal commented Aug 28, 2020

codecov bot commented Aug 28, 2020 •

edited

Loading

maze-runnar commented Aug 28, 2020

iamareebjamal Aug 28, 2020

lgtm-com bot commented Aug 28, 2020

lgtm-com bot commented Aug 28, 2020

iamareebjamal commented Aug 29, 2020

maze-runnar commented Aug 29, 2020

niranjan94 commented Aug 29, 2020

niranjan94 Aug 29, 2020

niranjan94 Aug 29, 2020

mariobehling commented Sep 2, 2020

mariobehling commented Sep 2, 2020

snitin315 commented Sep 2, 2020

feat: Adding a step two in wizard form #4905

feat: Adding a step two in wizard form #4905

Conversation

maze-runnar commented Aug 28, 2020

Short description of what this resolves:

Checklist

vercel bot commented Aug 28, 2020 • edited Loading

lgtm-com bot commented Aug 28, 2020

iamareebjamal commented Aug 28, 2020

codecov bot commented Aug 28, 2020 • edited Loading

Codecov Report

maze-runnar commented Aug 28, 2020

iamareebjamal Aug 28, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Aug 28, 2020

lgtm-com bot commented Aug 28, 2020

iamareebjamal commented Aug 29, 2020

maze-runnar commented Aug 29, 2020

niranjan94 commented Aug 29, 2020

niranjan94 Aug 29, 2020

Choose a reason for hiding this comment

niranjan94 Aug 29, 2020

Choose a reason for hiding this comment

mariobehling commented Sep 2, 2020

mariobehling commented Sep 2, 2020

snitin315 commented Sep 2, 2020

vercel bot commented Aug 28, 2020 •

edited

Loading

codecov bot commented Aug 28, 2020 •

edited

Loading