Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addition info step description #4941

Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Sep 2, 2020

Short description of what this resolves:

Refers #4905 (comment)

Follow up #4905

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/cke23id3y
✅ Preview: https://open-event-fro-git-fork-snitin315-fix-addition-step-desc-caada8.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #4941 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4941   +/-   ##
============================================
  Coverage        22.86%   22.86%           
============================================
  Files              484      484           
  Lines             5129     5129           
  Branches            18       18           
============================================
  Hits              1173     1173           
  Misses            3952     3952           
  Partials             4        4           
Impacted Files Coverage Δ
app/mixins/event-wizard.js 1.13% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81bb963...44207ed. Read the comment docs.

Copy link

@vsasvipul0605 vsasvipul0605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not required i guess.

@iamareebjamal iamareebjamal merged commit 5341413 into fossasia:development Sep 2, 2020
@snitin315 snitin315 deleted the fix/addition-step-description branch September 3, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants