Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: absorb fee required for donation ticket too #5118

Merged
merged 1 commit into from
Sep 22, 2020
Merged

fix: absorb fee required for donation ticket too #5118

merged 1 commit into from
Sep 22, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5096

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/n2vv077zt
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-absorb.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 21, 2020
@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-09-22 00-53-35

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #5118 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5118   +/-   ##
============================================
  Coverage        22.80%   22.80%           
============================================
  Files              489      489           
  Lines             5169     5169           
  Branches            35       35           
============================================
  Hits              1179     1179           
  Misses            3985     3985           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cad957...37a3704. Read the comment docs.

@iamareebjamal
Copy link
Member

Take out the tick box

There should be no tick box now, it's compulsory for now

@maze-runnar
Copy link
Contributor Author

Tickbox is read only, so it is required kind of.

@iamareebjamal iamareebjamal merged commit 513506e into fossasia:development Sep 22, 2020
@maze-runnar maze-runnar deleted the absorb branch September 22, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants