Public Schedule: Clicking on a filter moves the page #5826

[akash2408]

Fixes #5826

Short description of what this resolves:

adding ember install ember-router-scroll

Changes proposed in this pull request:

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/8t6059who
✅ Preview: https://open-event-frontend-git-development.eventyay.vercel.app

[sachinchauhan2889]

issue is still there. page is still moving after filtering sessions.

[lgtm-com]

This pull request introduces 1 alert when merging ef35cdd into 3a1e29c - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[sachinchauhan2889]

Try this...
just remove sessionChanged() action----> line 21-29.
and also remove 'sessionChanged' from this.addobserver()----> in line 18.

according to me this resolve issue.

[sachinchauhan2889]

why created this.

[akash2408]

After only removing session changed whenever we click on filter page will reload and moves up using previous scoll position this well save the earlier scroll postion of page and didnt moves the page up and down

[sachinchauhan2889]

you are right. 👍

[sachinchauhan2889]

good work @akash2408

[sachinchauhan2889]

@iamareebjamal sir, looks good to me.

please review

[codecov]

Codecov Report

Merging #5849 (85e8bb0) into development (3a1e29c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           development    #5849   +/-   ##
============================================
  Coverage        23.46%   23.46%           
============================================
  Files              512      512           
  Lines             5460     5459    -1     
  Branches            63       63           
============================================
  Hits              1281     1281           
+ Misses            4163     4162    -1     
  Partials            16       16           

Impacted Files	Coverage Δ
app/controllers/public/sessions.js	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1e29c...85e8bb0. Read the comment docs.

[mariobehling]

It is not working. The page should not move at all. Date, track and rooms still result in moving the page. The page should not move at all where-ever it is. It currently moves to the heading session.

[akash2408]

It is not working. The page should not move at all. Date, track and rooms still result in moving the page. The page should not move at all where-ever it is. It currently moves to the heading session.

Sir, Thats why i remove the content of sesssion changed function.The gif was of previous commit .please review again

[iamareebjamal]

@akash2408 That's because you pushed from development branch. Never ever create a PR from development branch. Now, we can't preview your work

[iamareebjamal]

Superseded by #5878