Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preserve scrolling position while filtering sessions #5878

Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Dec 2, 2020

Fixes #5826

@vercel
Copy link

vercel bot commented Dec 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ld72d3j5r
✅ Preview: https://open-event-frontend-git-akash2408-development.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #5878 (7dd08b9) into development (3a1e29c) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5878      +/-   ##
===============================================
- Coverage        23.46%   23.42%   -0.04%     
===============================================
  Files              512      511       -1     
  Lines             5460     5468       +8     
  Branches            63       65       +2     
===============================================
  Hits              1281     1281              
- Misses            4163     4170       +7     
- Partials            16       17       +1     
Impacted Files Coverage Δ
app/controllers/public/sessions.js 0.00% <0.00%> (ø)
app/routes/public/sessions.js 0.00% <ø> (ø)
app/components/widgets/forms/link-field.ts 60.00% <0.00%> (-5.22%) ⬇️
app/controllers/orders/view.js 6.45% <0.00%> (-0.22%) ⬇️
app/routes/pages.js 0.00% <0.00%> (ø)
app/controllers/public.js 0.00% <0.00%> (ø)
app/models/social-link.js 0.00% <0.00%> (ø)
app/mixins/event-wizard.js 0.89% <0.00%> (ø)
app/components/forms/orders/order-form.js 0.00% <0.00%> (ø)
app/routes/events/view/edit/sessions-speakers.js 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1e29c...a76c801. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 11b6b36 into fossasia:development Dec 2, 2020
@iamareebjamal iamareebjamal deleted the akash2408-development branch December 2, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Schedule: Clicking on a filter moves the page
2 participants