Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll added to create config layout #1960

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

neel1998
Copy link
Member

Fixes #1954

Changes: Added proper scrolling for horizontal view

Screenshot/s for the changes:
20190827_213123

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
create_config_scroll.zip

@neel1998 neel1998 added the Status: Review Required Requested reviews from peers and maintainers label Aug 27, 2019
@neel1998 neel1998 self-assigned this Aug 27, 2019
@mariobehling mariobehling merged commit 8b69f3e into fossasia:development Aug 28, 2019
@CloudyPadmal CloudyPadmal added Enhancement Improvement to an existing feature and removed Status: Review Required Requested reviews from peers and maintainers labels Aug 28, 2019
@neel1998 neel1998 mentioned this pull request Oct 1, 2019
5 tasks
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate Config File: Cannot scroll or see channels anymore in horizontal mode
3 participants