Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved UI Of Config Activity #1977

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Improved UI Of Config Activity #1977

merged 1 commit into from
Oct 18, 2019

Conversation

kshitiz-kumar
Copy link
Contributor

@kshitiz-kumar kshitiz-kumar commented Oct 1, 2019 •
edited
Loading

Fixes #1973

Changes: The Config Activity UI was unordered, so changes were made in the config layout by adding a number of views.

Screenshot/s for the changes:

WhatsAppVideo2019-10-01at24050PM

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
app-fdroid-debug.zip

@kshitiz-kumar kshitiz-kumar force-pushed the development branch 3 times, most recently from 31c6cfb to f23ea4b Compare October 1, 2019 10:26
@kshitiz-kumar
Copy link
Contributor Author

@CloudyPadmal please review.

ho-dor
ho-dor suggested changes Oct 1, 2019
View reviewed changes
app/src/main/java/io/pslab/activity/CreateConfigActivity.java Outdated
checkBox.setLayoutParams(checkBoxParams);
paramsListContainer.addView(checkBox, i);
for (int i = 0; i < params.length; i++) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra lines.

app/src/main/java/io/pslab/activity/CreateConfigActivity.java Outdated
CheckBoxAdapter box;
box = new CheckBoxAdapter(CreateConfigActivity.this, list);
paramsListContainer.setAdapter(box);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra lines.

@CloudyPadmal
Copy link
Collaborator

Can we reduce the margin between each checkbox item in list view? Currently it looks a bit much..

@neel1998
Copy link
Member

neel1998 commented Oct 1, 2019

As mentioned in the #1960 it would be better to add scroll to the entire layout and not just the parameters section. @kshitiz-kumar

@kshitiz-kumar
Copy link
Contributor Author

Can we reduce the margin between each checkbox item in list view? Currently it looks a bit much..

Yeah sure. I can give it a try

@kshitiz-kumar
Copy link
Contributor Author

As mentioned in the #1960 it would be better to add scroll to the entire layout and not just the parameters section. @kshitiz-kumar
Scroll is added to entire layout also. But I think it can be further optimised. I am working on it.

@kshitiz-kumar
Copy link
Contributor Author

kshitiz-kumar commented Oct 3, 2019 •
edited
Loading

@CloudyPadmal @neel1998 the required changes are made. The margin between checkboxes is reduced and the apk been updated. I think things are working fine.

Screen shot

@kshitiz-kumar
Copy link
Contributor Author

@CloudyPadmal please review.

@kshitiz-kumar
Copy link
Contributor Author

@CloudyPadmal please review.

@CloudyPadmal CloudyPadmal merged commit bee7485 into fossasia:development Oct 18, 2019
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
@kshitiz-kumar @makoteq
Improved UI Of Config Activity (fossasia#1977)
fe2e521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ho-dor ho-dor ho-dor requested changes

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improving the UI of generate config file activity
4 participants
@kshitiz-kumar @CloudyPadmal @neel1998 @ho-dor