-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional 'target' attribute for <button> #42
Add optional 'target' attribute for <button> #42
Conversation
Thanks for the PR! Do you know it's causing Travis to fail? |
Yep, tests on characters encoding are failing. But I don't think it's related to the code I wrote because when I forked the repo and ran the tests for the first time, they were already failing. |
Sounds like it is |
Great PR BTW! From now on we'll be directing PR's for bug fixes to the Merging this here - thanks! |
@rafibomb yeah those tests should just be on the branch where we're working on the encoding. You can revert them in develop/master |
@ClementParis016 It seems like we'll need to set this up for the menu items as well foundation/foundation-emails#465 Is that something you can help with? The method should be much the same. Thanks! |
@rafibomb Yep, it seems to be a quick one, I will submit a new PR in a few ;) (not sure if we could re-use this one ? I'm quite new to contributing on open source projects) |
Done, #54 |
<button>
components needs the ability to be passed atarget
attribute (that will be passed to the resulting<a>
element), which could be set to_blank
for use in the "view in browser" version of emails.See foundation/foundation-emails#432 for discussion.