Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add attributes to buttons and spacers #61

Merged
merged 5 commits into from
Sep 30, 2016

Conversation

yvmarques
Copy link
Contributor

This would be useful if we are adding attributes that help us to integrate the HTML with some WYSIWYG (as Mailchimp with mc:edit). Most of the existing components keep the attributes, but not the button.

I think the right place to put the attributes should be the element, as everything surrounding the link is just a helper for the link to show nicely.

This would be useful if we are adding attributes that help us to integrate the HTML with some WYSIWYG (as Mailchimp with mc:edit). Most of the existing components already include the attributes, but not the button.
@yvmarques yvmarques closed this Jul 5, 2016
@yvmarques yvmarques reopened this Jul 5, 2016
@yvmarques
Copy link
Contributor Author

I will try to add one test if I got time :)

@rafibomb
Copy link
Member

rafibomb commented Jul 5, 2016

Thanks for the PR - is this what you're looking for? #42

@yvmarques
Copy link
Contributor Author

yvmarques commented Jul 5, 2016

I am looking for more flexible solution for specific attributes that some 3rd services might use for their WYSIWYG, like for example, Mailchimp uses mc:edit to allow the users edit some portion of the text.

The same for CampaignMonitor uses cm_dontconvertlink to don't track links.

This PR allows we add as many attributes as we might need.

This should fix the test failing for a given spacer that might contain both arguments size (size-lg and size-sm) as we display twice the space with the helper class to show or display depends on the media queries.
@yvmarques yvmarques changed the title Allow to add attributes to buttons Allow to add attributes to buttons and spacers Jul 5, 2016
@cossssmin
Copy link

I was going to submit a PR, and then saw this - awesome!

It's currently the only thing preventing developing templates with custom attributes (like ESP specific) in Inky. I'm currently duplicating files from dist/ and working on the compiled HTML - it's a huge pain, especially when you need to update a page/partial with Inky: you need to start over with integrating the custom attributes...

Any planned release date? :)

@rafibomb
Copy link
Member

Awesome - merged! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants