-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to add attributes to buttons and spacers #61
Conversation
This would be useful if we are adding attributes that help us to integrate the HTML with some WYSIWYG (as Mailchimp with mc:edit). Most of the existing components already include the attributes, but not the button.
I will try to add one test if I got time :) |
Thanks for the PR - is this what you're looking for? #42 |
I am looking for more flexible solution for specific attributes that some 3rd services might use for their WYSIWYG, like for example, Mailchimp uses The same for CampaignMonitor uses This PR allows we add as many attributes as we might need. |
This should fix the test failing for a given spacer that might contain both arguments size (size-lg and size-sm) as we display twice the space with the helper class to show or display depends on the media queries.
I was going to submit a PR, and then saw this - awesome! It's currently the only thing preventing developing templates with custom attributes (like ESP specific) in Inky. I'm currently duplicating files from Any planned release date? :) |
Awesome - merged! Thanks! |
This would be useful if we are adding attributes that help us to integrate the HTML with some WYSIWYG (as Mailchimp with mc:edit). Most of the existing components keep the attributes, but not the button.
I think the right place to put the attributes should be the element, as everything surrounding the link is just a helper for the link to show nicely.