Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signP256 cheatcode #496

Closed
wants to merge 1 commit into from

Conversation

wilsoncusack
Copy link

Follow up to foundry-rs/foundry#6797, adds function definition for signP256 to Vm.sol

@mds1
Copy link
Collaborator

mds1 commented Jan 16, 2024

Thanks! Can you autogenerate Vm.sol using scripts/vm.py? The changes from foundry-rs/foundry#6785 were never added here, but will be included if it's autogenerated

@wilsoncusack
Copy link
Author

@mds1
image

@mds1
Copy link
Collaborator

mds1 commented Jan 17, 2024

@DaniPopes I'm looking at foundry-rs/foundry#6785 and it aded a new group called Base64. Feels like overkill for that to have it's own group. What do you think about removing that group and moving the base64 cheats to the Utilities group?

@wilsoncusack
Copy link
Author

Does it make sense to leave the byes64 issue to a separate PR?

@mds1
Copy link
Collaborator

mds1 commented Jan 17, 2024

Replaced by #497

@mds1 mds1 closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants