Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signP256 Cheat #6797

Merged
merged 10 commits into from
Jan 16, 2024
Merged

signP256 Cheat #6797

merged 10 commits into from
Jan 16, 2024

Conversation

wilsoncusack
Copy link
Contributor

Motivation

Resolves #6782

Solution

DaniPopes
DaniPopes requested changes Jan 15, 2024
View reviewed changes
crates/cheatcodes/spec/src/vm.rs Outdated Show resolved Hide resolved
crates/cheatcodes/spec/src/vm.rs Show resolved Hide resolved
testdata/cheats/SignP256.t.sol Show resolved Hide resolved
@wilsoncusack
Copy link
Contributor Author

@mds1 @DaniPopes not sure what to do re this rust fmt test. If I run cargo fmt there's a huge diff.

@mds1
Copy link
Collaborator

mds1 commented Jan 15, 2024

Foundry uses the nightly fmt, so use cargo +nightly fmt

mattsse
mattsse reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaniPopes thoughts on p256 crate?

can we reuse anything from alloy here?

@DaniPopes
Copy link
Member

@DaniPopes thoughts on p256 crate?

Same as k256

can we reuse anything from alloy here?

No

mattsse
mattsse approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

pending @mds1 @DaniPopes

DaniPopes
DaniPopes requested changes Jan 16, 2024
View reviewed changes
crates/cheatcodes/spec/src/vm.rs Outdated Show resolved Hide resolved
crates/cheatcodes/spec/src/vm.rs Outdated Show resolved Hide resolved
DaniPopes
DaniPopes approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattsse
Copy link
Member

mattsse commented Jan 16, 2024

can upstream to forge-std now

@mattsse mattsse merged commit 36044da into foundry-rs:master Jan 16, 2024
20 checks passed
@wilsoncusack wilsoncusack mentioned this pull request Jan 16, 2024
Closed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 left review comments

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

secp256r1 sign cheat code
4 participants
@wilsoncusack @mds1 @DaniPopes @mattsse