fix: avoid panic on missing CREATE2 deployer #7838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
May 2, 2024
0xgregthedev
pushed a commit
to phylaxsystems/phoundry
that referenced
this pull request
May 2, 2024
* fix: avoid panic on missing CREATE2 deployer * rm println * rm println
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7833
Overriden
createhandler was returningFrameResult::Createwhen reverting on missing CREATE2 deployer which caused it to be received byinsert_create_outcomehook of default handler register which was panicking because it never seen the initial call.Solution
Return
FrameResult::Calland change order of things a bit so that stack of create2 register is correct once we receive revert ininsert_call_outcome