This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
bug: specific Reno forge script not working #1042
Labels
bug
Inconsistencies or issues which will cause a problem for users or implementors.
Comments
Eikix
added
the
bug
|
raised foundry-rs/foundry#7833 |
|
@greged93 Closed by foundry-rs/foundry#7838 no? |
github-project-automation
bot
moved this from 🆕 Backlog
to ✅ Done
in Kakarot on Starknet
anukkrit149
pushed a commit
to karnotxyz/kakarot-rpc
that referenced
this issue
Aug 9, 2024
<!--- Please provide a general summary of your changes in the title above --> <!-- Give an estimate of the time you spent on this PR in terms of work days. Did you spend 0.5 days on this PR or rather 2 days? --> Time spent on this PR: ## Pull request type <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [ ] Bugfix - [ ] Feature - [x] Code style update (formatting, renaming) - [x] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Resolves kkrt-labs#897 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - rename `bytes_i_to_uint256` to `bytes_big_endian_to_uint256` - simplify boolean condition for `is_bytes_len_16_bytes_or_less` - follow conventions by having `bytes_len` before `bytes` - rename `compute_half_uint256` to `compute_half_uint256_from_bytes` - improved readability for `pow256_rev` - use `pow256_rev` instead of `pow` from starkware lib: from 2419 to 1261 steps With `pow` from starkware lib <img width="452" alt="before opti" src="https://github.com/kkrt-labs/kakarot/assets/92337658/0c56d88b-834b-4fae-abba-a3e987955164"> With `pow256_rev` <img width="536" alt="after opti" src="https://github.com/kkrt-labs/kakarot/assets/92337658/f1489bc3-016d-4303-81f7-2b0e1df00fdd"> <!-- Reviewable:start --> - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1042) <!-- Reviewable:end --> --------- Co-authored-by: Clément Walter <clement0walter@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
Warning⚠️ - needs more scoping
Kakarot RPC version:
v0.7.2
Current behavior:
Reno is trying to run a specific script to deploy his smart wallet on Kakarot Sepolia. He has managed to deploy it to Sepolia L1.
He gave us the script he's running.
Tasks
For archive, text Elias.
After opening the archive:
from Reno:
Bug:
Expected behavior:
The text was updated successfully, but these errors were encountered: