Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vyper support for forge test #7981

Closed
wants to merge 3 commits into from
Closed

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented May 24, 2024

Motivation

Adds Vyper support for forge test and some tests for it.

Solution

We should probably get rid of CompilationError generic on ProjectCompileOutput as it now ended up in MultiContractRunner and it doesn't make much sense there, though I think we'd have a compiler generic there at some point so should be OK to keep for now

CI will likely fail as no vyper is available, what's the right way to enable those tests? should we just download binary as it's done in compilers or we could inject it into CI env?

Closes #5934

@klkvr klkvr force-pushed the klkvr/generic-forge-test branch from 282c28f to 92be48a Compare May 24, 2024 04:11
@klkvr klkvr force-pushed the klkvr/generic-forge-test branch from 92be48a to 46867ec Compare May 24, 2024 14:06
@DaniPopes DaniPopes mentioned this pull request May 24, 2024
@DaniPopes
Copy link
Member

CI will likely fail as no vyper is available, what's the right way to enable those tests? should we just download binary as it's done in compilers or we could inject it into CI env?

We could extract just the version manager from here: https://github.com/crypdoughdoteth/vyper-rs

@klkvr
Copy link
Member Author

klkvr commented Jun 4, 2024

Superseded by #8011

@klkvr klkvr closed this Jun 4, 2024
@klkvr klkvr deleted the klkvr/generic-forge-test branch June 19, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vyper Support
2 participants