bump compilers #8011
Merged
bump compilers #8011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jun 3, 2024
DaniPopes
approved these changes
Jun 3, 2024
|
Should we add a way to disable Vyper explicitly through foundry.toml? Currently this will probably break some of codebases containing Vyper code because of different import resolution in Vyper 0.3.10 for standard json input |
|
hmm, I think we can wait until we get some feedback? |
|
Guys, this PR breaks my complete snekmate pipeline ( https://github.com/pcaversaccio/snekmate/actions/runs/9363205334/job/25773476188?pr=207 (that's the PR pcaversaccio/snekmate#207) Can we please fix this because the timing is really unfortunate since I planned to merge this PR today... (after 3 months of work) Cc: @mattsse @klkvr @grandizzy |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ref foundry-rs/compilers#128
Solution