-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/proxmox implementation #745
Conversation
this is in regards with low-privileged user credentials
@otnxSl thank you for your contribution! As this is your first code contribution, please read the following Contributor License Agreement (CLA). If you agree with the CLA, please reply with the following information:
Contributor License Agreement
Contribution License AgreementThis Contribution License Agreement ("Agreement") governs your Contribution(s) (as defined below) and conveys certain license rights to Fox-IT B.V. ("Fox-IT") for your Contribution(s) to Fox-IT"s open source Dissect project. This Agreement covers any and all Contributions that you ("You" or "Your"), now or in the future, Submit (as defined below) to this project. This Agreement is between Fox-IT B.V. and You and takes effect when you click an “I Accept� button, check box presented with these terms, otherwise accept these terms or, if earlier, when You Submit a Contribution.
|
Hey @otnxSl. Thank you for your contribution, looks like quite some work went into this! Please allow us some time to start the review process on this PR. We try to get back to you as soon as possible! |
@DissectBot agree |
Depends on #832 for the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 75.51% 75.35% -0.17%
==========================================
Files 305 309 +4
Lines 26348 26496 +148
==========================================
+ Hits 19897 19966 +69
- Misses 6451 6530 +79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Test file uploaded in a separate PR because of annoying GitHub bugs with LFS on PR branches: #833 |
Will be continued at #837 |
Added Support for systems running Proxmox Virtual Environment using the default ext4 filesystem configuration.