Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SQLite table exist checks #958

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

JSCU-CNI
Copy link
Contributor

This PR makes sure the wpndatabase plugin checks if the NotificationHandler table exists before attempting to read from it.

@JSCU-CNI JSCU-CNI changed the title Add improved SQLite check in Windows Notification plugin Improve SQLite table exist checks Nov 27, 2024
dissect/target/plugins/os/unix/esxi/_os.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/catroot.py Outdated Show resolved Hide resolved
dissect/target/plugins/apps/browser/iexplore.py Outdated Show resolved Hide resolved
dissect/target/plugins/apps/browser/iexplore.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/catroot.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/activitiescache.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/notifications.py Outdated Show resolved Hide resolved
JSCU-CNI and others added 2 commits November 28, 2024 14:45
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 25.45455% with 41 lines in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (5c9eedf) to head (0e6d5da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/unix/esxi/_os.py 0.00% 28 Missing ⚠️
dissect/target/loaders/itunes.py 0.00% 3 Missing ⚠️
dissect/target/plugins/apps/browser/iexplore.py 40.00% 3 Missing ⚠️
...ssect/target/plugins/os/windows/activitiescache.py 0.00% 3 Missing ⚠️
dissect/target/plugins/os/windows/catroot.py 50.00% 3 Missing ⚠️
dissect/target/plugins/os/windows/notifications.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
- Coverage   77.91%   77.89%   -0.02%     
==========================================
  Files         324      324              
  Lines       27869    27879      +10     
==========================================
+ Hits        21714    21717       +3     
- Misses       6155     6162       +7     
Flag Coverage Δ
unittests 77.89% <25.45%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit af1abe4 into fox-it:main Nov 28, 2024
16 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/wpndatabase-table-check branch November 28, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants