Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Make RawMessage fields public #1184

Merged
merged 1 commit into from
Jun 24, 2024
Merged

rust: Make RawMessage fields public #1184

merged 1 commit into from
Jun 24, 2024

Conversation

A-K-O-R-A
Copy link
Contributor

Changelog

RawMessage fields are now public

Docs

None

Description

Currently the RawMessageStream is useless because the API does not expose the fields of the RawMessage struct. To solve this issue the fields of RawMessages are now marked as pub.

References

This PR is the same as #934

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2024

CLA assistant check
All committers have signed the CLA.

@A-K-O-R-A A-K-O-R-A changed the title Make RawMessage fields public rust: Make RawMessage fields public Jun 15, 2024
Copy link
Member

@jtbandes jtbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtbandes jtbandes merged commit 179e675 into foxglove:main Jun 24, 2024
24 checks passed
@jtbandes jtbandes mentioned this pull request Jun 24, 2024
jtbandes added a commit that referenced this pull request Jun 24, 2024
Releasing changes from #1184
@jtbandes
Copy link
Member

Published 0.9.1 https://crates.io/crates/mcap/0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants