fix(fseek&ftell): fix a bug of fseek/ftell on win, which fail to work when file size > 2GB(max bound of long type) #1222
Conversation
… when file size > 2GB(max bound of long type)
|
Thanks for the contribution! It looks like we already have a CI check that runs tests on Windows. Would you be able to add a test case to ensure this works as expected? |
|
my test env is VS2019 with msvc1929, read a mcap file > 2GB will reproduce the problem, or you can just test fseek&ftell API derictly on win, i'm sorry for my pr not pass your CI due to my lack of consideration, or it should just be a issue. |
|
in LogTimeOrder will act more bad, nothing will return by readMessages API, in FileOrder still can get data although file size get wrong -1 |
|
@no5-aaron-wu Are you able to update this PR to add the unit test requested? It also looks like some other aspects of the PR are failing CI. Consider merging latest main and the swift CI issue might be resolved. |
|
Closing this out since we've not heard back. We are happy to re-visit if you can address the issue around unit tests. |
when file size > 2GB, fseek will work wrong, ftell return -1 on windows