Fix hashFiles() input for C++ CI caching #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
reviewed
Oct 4, 2022
| @@ -63,12 +63,12 @@ ci-image: hdoc-build | |||
|
|
|||
| .PHONY: ci | |||
| ci: ci-image | |||
| docker run -t --rm -v $(CURDIR):/mcap/cpp mcap_cpp_ci ./build.sh | |||
| docker run -t --rm -v $(CURDIR):/mcap/cpp -v $(HOME)/.conan/data:/root/.conan/data mcap_cpp_ci ./build.sh | |||
There was a problem hiding this comment.
Why do we want the user's local install of conan to interact with the version contained inside Docker?
There was a problem hiding this comment.
To take advantage of caching. The "user" here is ci
There was a problem hiding this comment.
I guess this makes sense as a way to allow it to be cached – but would caching the Docker layers also help?
There was a problem hiding this comment.
We already cache the Docker layers, and the protobuf library (conan dependency) is rebuilt on virtually every PR which is why CI is so slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
This PR volume mounts
$HOME/.conan/datato/root/.conan/datainside Docker containers specifically for theciMakefile commands, and fixeshashFiles()usage in GitHub Actions to ingest conanfile.py inputs rather than the output artifact directory (which does not exist when the hash check is done). The end result is caching of conan build artifacts between CI runs, so the majority of CI time is no longer spent recompiling the protobuf library.New CI output: