Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provenance attestation when publishing to NPM #48

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Add provenance attestation when publishing to NPM #48

merged 1 commit into from
Apr 8, 2024

Conversation

jtbandes
Copy link
Member

@jtbandes jtbandes commented Apr 6, 2024

Changelog

None

Description

This adds a provenance attestation to the published package so consumers can verify that the package was built on GitHub Actions:

The package will appear like this on npm:

defunctzombie
defunctzombie approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@defunctzombie defunctzombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the yarn publish comment. Makes sense that to publish to npm you need the npm tool.

@jtbandes
Copy link
Member Author

jtbandes commented Apr 8, 2024

Same comment as other PR: I am keeping the comment since I believe yarn pack && npm publish package.tgz looks unusual

@jtbandes jtbandes merged commit 464dfe0 into main Apr 8, 2024
2 checks passed
@jtbandes jtbandes deleted the jacob/provenance branch April 8, 2024 17:07
@achim-k achim-k mentioned this pull request Apr 24, 2024
Merged
achim-k added a commit that referenced this pull request Apr 24, 2024
@achim-k
v5.0.4 (#50)
dda2356 
### Changelog
v5.0.4 Release

### Description
Changes since v5.0.3

- #49
- #48
- #47
@jtbandes jtbandes mentioned this pull request Apr 24, 2024
Merged
jtbandes added a commit that referenced this pull request Apr 24, 2024
@jtbandes
ci: update node to 20.x (#51)
4cd0390 
### Changelog
None

### Description
#48 didn't actually work because `--provenance` is not a thing in v16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defunctzombie defunctzombie defunctzombie approved these changes

@achim-k achim-k Awaiting requested review from achim-k

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtbandes @defunctzombie