fix: payment reco for jv with negative dr or cr amount #44197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljain112
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
github-actions
bot
added
accounts
needs-tests
ruthra-kumar
approved these changes
Nov 20, 2024
ruthra-kumar
added
backport version-15-hotfix
backport version-14-hotfix
This was referenced Nov 20, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Nov 20, 2024
…-44197 fix: payment reco for jv with negative dr or cr amount (backport #44197)
ruthra-kumar
added a commit
that referenced
this pull request
Nov 20, 2024
…-44197 fix: payment reco for jv with negative dr or cr amount (backport #44197)
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I checked the GL Entry, and it looks inconsistent.
IMO it's also important to make it consistent, where amount in transaction currency is also reversed like other amounts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Payment Reconciliation for Journal Entries with negative debit or credit amounts is not supported.
Steps To Replicate:
backport version-15