Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: toggle debit credit amounts for transaction currency too; minor … #44263

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: toggle debit credit amounts for transaction currency too; minor … #44263

wants to merge 2 commits into from

Conversation

vorasmit
Copy link
Collaborator

@vorasmit vorasmit commented Nov 21, 2024 •
edited
Loading

Fixes: #44197 (comment)

Issue

Amount in transaction currency is -ve and on credit side.

image

  • Ensures amount is transaction currency is updated consistently like amount in account currency
  • Refactor, cleaner code with reduced duplication

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Nov 21, 2024
@vorasmit vorasmit marked this pull request as ready for review November 21, 2024 14:14
@vorasmit vorasmit removed the needs-tests This PR needs automated unit-tests. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vorasmit