fix: move validate_total_debit_and_credit fromvalidate toon_submit in Journal Entry
#44339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've moved the validation to |
ruthra-kumar
added a commit
that referenced
this pull request
Dec 3, 2024
…-44339 fix: move `validate_total_debit_and_credit` from`validate` to`on_submit` in Journal Entry (backport #44339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://support.frappe.io/helpdesk/tickets/20084
Total Debit and Credit are shown same even when there is a difference amount.
Solution:
Remove the validation
validate_total_debit_and_creditand let the user save Journal Entry. This will recalculate and correct the amounts shown.Instead, validate
validate_total_debit_and_creditinon_submit