Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move validate_total_debit_and_credit fromvalidate toon_submit in Journal Entry #44339

Merged
merged 2 commits into from
Dec 3, 2024

refactor: validate debit and credit on before_submit

c3ace82
Select commit
Loading
Failed to load commit list.
Merged

fix: move validate_total_debit_and_credit fromvalidate toon_submit in Journal Entry #44339

refactor: validate debit and credit on before_submit
c3ace82
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Dec 3, 2024 in 2s

1 rule matches and 5 potential rules

⚠️ The pull request has been merged by @ruthra-kumar

Rule: backport to develop (backport)

  • label="backport develop"
  • merged [📌 backport requirement]

Rule: backport to version-14-hotfix (backport)

  • label="backport version-14-hotfix"
  • merged [📌 backport requirement]

✅ Rule: backport to version-15-hotfix (backport)

  • label="backport version-15-hotfix"
  • merged [📌 backport requirement]

Rule: backport to version-13-hotfix (backport)

  • label="backport version-13-hotfix"
  • merged [📌 backport requirement]

Rule: Automatic merge on CI success and review (merge)

  • #approved-reviews-by>=1
  • -closed [📌 merge requirement]
  • status-success=Semantic Pull Request
  • status-success=Sider
  • -conflict [📌 merge requirement]
  • -draft [📌 merge requirement]
  • label!=dont-merge
  • label!=squash
  • status-success=Patch Test
  • status-success=Python Unit Tests (1)
  • status-success=Python Unit Tests (2)
  • status-success=Python Unit Tests (3)
  • status-success=linters
  • any of: [📌 merge -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🛡 GitHub branch protection]
    • check-success = Patch Test
    • check-neutral = Patch Test
    • check-skipped = Patch Test
  • any of: [🛡 GitHub branch protection]
    • check-success = Python Unit Tests (1)
    • check-neutral = Python Unit Tests (1)
    • check-skipped = Python Unit Tests (1)
  • any of: [🛡 GitHub branch protection]
    • check-success = Python Unit Tests (2)
    • check-neutral = Python Unit Tests (2)
    • check-skipped = Python Unit Tests (2)
  • any of: [🛡 GitHub branch protection]
    • check-success = Python Unit Tests (3)
    • check-neutral = Python Unit Tests (3)
    • check-skipped = Python Unit Tests (3)
  • any of: [🛡 GitHub branch protection]
    • check-success = Python Unit Tests (4)
    • check-neutral = Python Unit Tests (4)
    • check-skipped = Python Unit Tests (4)
  • any of: [🛡 GitHub branch protection]
    • check-success = linters
    • check-neutral = linters
    • check-skipped = linters

Rule: Automatic squash on CI success and review (merge)

  • #approved-reviews-by>=1
  • -closed [📌 merge requirement]
  • label=squash
  • status-success=Sider
  • -conflict [📌 merge requirement]
  • -draft [📌 merge requirement]
  • label!=dont-merge
  • status-success=Patch Test
  • status-success=Python Unit Tests (1)
  • status-success=Python Unit Tests (2)
  • status-success=Python Unit Tests (3)
  • status-success=linters
  • any of: [📌 merge -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🛡 GitHub branch protection]
    • check-success = Patch Test
    • check-neutral = Patch Test
    • check-skipped = Patch Test
  • any of: [🛡 GitHub branch protection]
    • check-success = Python Unit Tests (1)
    • check-neutral = Python Unit Tests (1)
    • check-skipped = Python Unit Tests (1)
  • any of: [🛡 GitHub branch protection]
    • check-success = Python Unit Tests (2)
    • check-neutral = Python Unit Tests (2)
    • check-skipped = Python Unit Tests (2)
  • any of: [🛡 GitHub branch protection]
    • check-success = Python Unit Tests (3)
    • check-neutral = Python Unit Tests (3)
    • check-skipped = Python Unit Tests (3)
  • any of: [🛡 GitHub branch protection]
    • check-success = Python Unit Tests (4)
    • check-neutral = Python Unit Tests (4)
    • check-skipped = Python Unit Tests (4)
  • any of: [🛡 GitHub branch protection]
    • check-success = linters
    • check-neutral = linters
    • check-skipped = linters
💖  Mergify is proud to provide this service for free to open source projects.

🚀  You can help us by becoming a sponsor!

1 not applicable rule

Rule: Auto-close PRs on stable branch (close, comment)

  • all of:
    • any of:
      • base=version-12
      • base=version-13
      • base=version-14
      • base=version-15
      • base=version-16
    • all of:
      • author!=ankush
      • author!=deepeshgarg007
      • author!=frappe-pr-bot
      • author!=gavindsouza
      • author!=mergify[bot]
      • author!=nabinhait
      • author!=rohitwaghchaure
      • author!=surajshetty3416
Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

View more details on Mergify