Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

New Queues, Exchanges, Bindings not been created. #54

Closed
ocristian opened this issue Mar 8, 2021 · 2 comments · Fixed by #63
Closed

New Queues, Exchanges, Bindings not been created. #54

ocristian opened this issue Mar 8, 2021 · 2 comments · Fixed by #63
Assignees
@rwanderc
Labels
bug Something isn't working v2.1.7 v2.2.3 v2.3.1 v2.4.0

Comments

@ocristian
Copy link
Collaborator

ocristian commented Mar 8, 2021 •
edited
Loading

Queues, exchanges or bindings not existing in the broker yet are not being automatically created when using @RabbitListener.

A possible root cause for it is because we have specific declaringAdmins, in those declarebles created by MultiRabbit.
This info is evaluated by RabbitAdmin while filtering the declarables.

Here, we can see the obj status during that evaluation.
Queue declaringAdmins is different than this.beanName

dec = {Queue@11016} "Queue [name=new-queue-name, durable=true, autoDelete=false, exclusive=false, arguments={},   actualName=new-queue-name]"  
 name = "new-queue-name"   
 durable = true  
 exclusive = false  
 autoDelete = false    
 actualName = "new-queue-name"  
 shouldDeclare = true  
 declaringAdmins = {ArrayList@11026}  size = 1  
  0 = "eventbus-admin" 
 ignoreDeclarationExceptions = true  
 arguments = {HashMap@11027}  size = 0  
this.explicitDeclarationsOnly = false  
this.beanName = "amqpAdmin"
rwanderc added a commit that referenced this issue Mar 9, 2021
@rwanderc
GH-54 Fixed queue declaring error in RabbitMQ and introduced integrat…
4053817 
…ion tests with testcontainers
@rwanderc rwanderc self-assigned this Mar 9, 2021
@rwanderc rwanderc added bug Something isn't working v2.4.0 labels Mar 9, 2021
@rwanderc
Copy link
Contributor

rwanderc commented Mar 9, 2021

Thank @ocristian for opening the issue. That's fixed in main and will be merged and released in 2.4.0.

rwanderc added a commit that referenced this issue Mar 9, 2021
@rwanderc
GH-54 Fixed queue declaring error and introduced integration tests
f2e6af7
rwanderc added a commit that referenced this issue Mar 11, 2021
@rwanderc
GH-54 Fixed queue declaring error and introduced integration tests
2f930c2
rwanderc added a commit that referenced this issue Mar 11, 2021
@rwanderc
GH-54 Fixed queue declaring error and introduced integration tests
f843cb2
rwanderc added a commit that referenced this issue Mar 11, 2021
@rwanderc
GH-54 Fixed queue declaring error and introduced integration tests
65f55da
ocristian added a commit that referenced this issue May 19, 2021
@ocristian
#54 - Fixed issue that prevents creating new queues, exchangers and/o…
425acf4 
…r bindings. (#63)

It was being overwritten, as we were using its reference instead of a new instance.
In addition, the bean name was being set after calling afterPropertiesSet, which caused the registered bean to have no name.
Those two problems cause that during the declaration of the queues,exchange or bindings, the registered RabbitAdmin was not identified as DeclarableAdmins.
RabbitAdmin filter the declarebles here: RabbitAdmin.filterDeclarables(.....) and the admin checks here: declarableByMe(...)

Introducing Github Actions to build, release and publishing artifacts to maven central
@ocristian ocristian linked a pull request May 19, 2021 that will close this issue
#54 - Fixed issue that prevents creating new queues, exchangers and/or bindings. #63
Merged
@ocristian
Copy link
Collaborator Author

Issue fixed on release v2.4.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rwanderc rwanderc

Labels
bug Something isn't working v2.1.7 v2.2.3 v2.3.1 v2.4.0
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#54 - Fixed issue that prevents creating new queues, exchangers and/or bindings.
2 participants
@ocristian @rwanderc