This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
#54 - Fixed issue that prevents creating new queues, exchangers and/or bindings. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixoldenburg
approved these changes
Apr 29, 2021
mohammedalics
approved these changes
Apr 29, 2021
rwanderc
suggested changes
May 9, 2021
.../src/main/java/org/springframework/boot/autoconfigure/amqp/MultiRabbitAutoConfiguration.java
Show resolved
Hide resolved
sergioasantiago
approved these changes
May 12, 2021
rwanderc
approved these changes
May 18, 2021
|
@ocristian I think it's important to keep an eye on #63 (comment) |
…gers and/or bindings. It was being overwritten, as we were using its reference instead of a new instance. In addition, the bean name was being set after calling afterPropertiesSet, which caused the registered bean to have no name. Those two problems cause that during the declaration of the queues,exchange or bindings, the registered RabbitAdmin was not identified as DeclarableAdmins. RabbitAdmin filter the declarebles here: RabbitAdmin.filterDeclarables(.....) and the admin checks here: declarableByMe(...) Introducing Github Actions to build, release and publishing artifacts to maven central
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem registering the Admins. It was being overwritten as we were using its reference instead of a new instance.
In addition, the bean name was being set after calling afterPropertiesSet, which caused the registered bean to have no name.
Those two problems cause that during the declaration of the queues, exchange or bindings, the registered RabbitAdmin was not identified as DeclarableAdmins.
More info on how RabbitAdmin filter the declarebles here: RabbitAdmin.filterDeclarables(.....) and the admin checks here: declarableByMe(...)
Introducing Github Actions to build, release and publishing artifacts to maven central