Bug/problem when version files contains many occurrences #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or a literal Change: 'isARegExp' function added to check if a given string is a regular expression or a literal Use 'isARegExp' function instead of hardcoding the regular expression in 'updateVersionOfFiles' The function compiles the regular expression and checks for special regex characters
Change the 'version_files' array in 'package.json' to include a new entry for 'other-version.txt'. Update the regular expression to correctly match the version number in the file.
…variable format Change the way VersionData.updateVersionFiles handles the file format. Instead of using a single string for both file name and substring, use a format where they are separated by a colon (:). This allows for more flexibility in handling different file formats.
sergiotejon
deleted the
bug/problem_when_version_files_contains_many_occurrences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.