-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache.function
method
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `function_` has to return a valid value. `undefined` isn't a valid value
This lets you simplify the code from: ```js const foo = await generate(); await cache.set('key', foo); return foo; ``` to: ```js return set('key', await generate()); ```
This enables easy overloads support. Disk caching helps functions that take a while to execute and sync functions generally don't. If necessary, a user-side solution would be: ```ts cache.function(async x => syncFunction(x)) ``` There's no way to support overloads on sync functions: https://stackoverflow.com/q/59125705/288906 Types could be fixed to at least support overloaded async functions but I couldn't figure out how.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets you skip the whole
if cached, return cached, else get new value and cache it
Before
After
Next steps