-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache.function
method
#5
Merged
Commits on Dec 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2d33249 - Browse repository at this point
Copy the full SHA 2d33249View commit details -
Configuration menu - View commit details
-
Copy full SHA for f64791f - Browse repository at this point
Copy the full SHA f64791fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dade8d0 - Browse repository at this point
Copy the full SHA dade8d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3c3bfb - Browse repository at this point
Copy the full SHA b3c3bfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a2b5ef0 - Browse repository at this point
Copy the full SHA a2b5ef0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea909c6 - Browse repository at this point
Copy the full SHA ea909c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40bb4f1 - Browse repository at this point
Copy the full SHA 40bb4f1View commit details -
Now `function_` has to return a valid value. `undefined` isn't a valid value
Configuration menu - View commit details
-
Copy full SHA for a94e9c8 - Browse repository at this point
Copy the full SHA a94e9c8View commit details -
Make
cache.set
return the value itselfThis lets you simplify the code from: ```js const foo = await generate(); await cache.set('key', foo); return foo; ``` to: ```js return set('key', await generate()); ```
Configuration menu - View commit details
-
Copy full SHA for ec128fa - Browse repository at this point
Copy the full SHA ec128faView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee9799b - Browse repository at this point
Copy the full SHA ee9799bView commit details
Commits on Dec 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7ab8bcc - Browse repository at this point
Copy the full SHA 7ab8bccView commit details
Commits on Dec 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 04a5dce - Browse repository at this point
Copy the full SHA 04a5dceView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5a7202 - Browse repository at this point
Copy the full SHA a5a7202View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaacbfe - Browse repository at this point
Copy the full SHA aaacbfeView commit details
Commits on Jan 6, 2020
-
Only support async functions (TypeScript types)
This enables easy overloads support. Disk caching helps functions that take a while to execute and sync functions generally don't. If necessary, a user-side solution would be: ```ts cache.function(async x => syncFunction(x)) ``` There's no way to support overloads on sync functions: https://stackoverflow.com/q/59125705/288906 Types could be fixed to at least support overloaded async functions but I couldn't figure out how.
Configuration menu - View commit details
-
Copy full SHA for 426a04e - Browse repository at this point
Copy the full SHA 426a04eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cada340 - Browse repository at this point
Copy the full SHA cada340View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01b371d - Browse repository at this point
Copy the full SHA 01b371dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dc5025 - Browse repository at this point
Copy the full SHA 6dc5025View commit details -
Configuration menu - View commit details
-
Copy full SHA for aceb673 - Browse repository at this point
Copy the full SHA aceb673View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d9b488 - Browse repository at this point
Copy the full SHA 0d9b488View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.