Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Localization with php-i18n and convert to json #117

Closed
11 of 12 tasks
Tracked by #52
philipbrembeck opened this issue Feb 24, 2022 · 0 comments · Fixed by #121
Closed
11 of 12 tasks
Tracked by #52

Simplify Localization with php-i18n and convert to json #117

philipbrembeck opened this issue Feb 24, 2022 · 0 comments · Fixed by #121
Assignees
@philipbrembeck
Labels
enhancement New feature or request low priority Fix when there is time
Milestone
v2.x

Comments

@philipbrembeck
Copy link
Collaborator

philipbrembeck commented Feb 24, 2022 •
edited
Loading

Proposed changes

Add philipp15b/php-i18n i18n.class.php via composer:

$ composer require philipp15b/php-i18n

and convert current localizations to JSON.

Tasks

  • Require class
  • Change localization folder to l10n
  • Convert php-arrays to json
  • Implement in all applicable pages:
    • script.php
    • impressum.php
    • privacy-policy.php
    • offline.php
    • main.php
  • Debate restructuring language-code named folders
  • Edit README!
  • Push & publish
@philipbrembeck philipbrembeck added enhancement New feature or request low priority Fix when there is time labels Feb 24, 2022
@philipbrembeck philipbrembeck added this to the v2.x milestone Feb 24, 2022
@philipbrembeck philipbrembeck self-assigned this Feb 24, 2022
@philipbrembeck philipbrembeck mentioned this issue Feb 24, 2022
Open
31 tasks
philipbrembeck added a commit that referenced this issue Mar 1, 2022
@philipbrembeck
Requiring php-i18n [#117]
dcb6b92
philipbrembeck added a commit that referenced this issue Mar 1, 2022
@philipbrembeck
Merge pull request #118 from JokeNetwork/Add-i18n
d2870e9 
Requiring `php-i18n` [#117]
philipbrembeck referenced this issue Mar 2, 2022
@philipbrembeck
Merge pull request #119 from JokeNetwork/JSON-l10n
cf60623 
❤️‍🔥 Converted l10n from array to `json`
philipbrembeck referenced this issue Mar 2, 2022
@philipbrembeck
↔️ Changed localization → l10n
237728a
philipbrembeck added a commit that referenced this issue Mar 4, 2022
@philipbrembeck
📌🌐 Removed $langArray, added php-i18n [#117]
537beda
@philipbrembeck philipbrembeck mentioned this issue Mar 4, 2022
Merged
3 tasks
philipbrembeck added a commit that referenced this issue Mar 4, 2022
@philipbrembeck
Fully implemented i18n.class.php [#117]
7922d62
gitgauner added a commit that referenced this issue Mar 4, 2022
@gitgauner
Merge pull request #121 from JokeNetwork/Implement_i18n [#117]
598f012 
Fully implemented `i18n.class.php` [#117]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipbrembeck philipbrembeck

Labels
enhancement New feature or request low priority Fix when there is time
Projects
None yet
Milestone
v2.x
Development

Successfully merging a pull request may close this issue.

Fully implemented i18n.class.php frontendnetwork/veganify
1 participant
@philipbrembeck