Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implemented i18n.class.php #121

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Fully implemented i18n.class.php #121

merged 2 commits into from
Mar 4, 2022

Conversation

philipbrembeck
Copy link
Collaborator

Proposed changes

See #117. This closes #117.

Tasks

@philipbrembeck philipbrembeck added enhancement New feature or request high priority Fix asap labels Mar 4, 2022
@auto-assign auto-assign bot requested a review from gitgauner March 4, 2022 21:33
index.php Outdated
die();
}
require('vendor/autoload.php');
$i18n = new i18n('/var/www/virtual/jake/vegancheck.me/l10n/{LANGUAGE}.json', '/var/www/virtual/jake/vegancheck.me/langcache/', 'en');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line exceeds 120 characters; contains 133 characters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to change to absolute paths.

index.php Outdated
die();
}
require('vendor/autoload.php');
$i18n = new i18n('/var/www/virtual/jake/vegancheck.me/l10n/{LANGUAGE}.json', '/var/www/virtual/jake/vegancheck.me/langcache/', 'en');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to change to absolute paths.

@codeclimate
Copy link

codeclimate bot commented Mar 4, 2022

Code Climate has analyzed commit 7922d62 and detected 0 issues on this pull request.

View more on Code Climate.

@philipbrembeck philipbrembeck requested a review from gitgauner March 4, 2022 21:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gitgauner gitgauner merged commit 598f012 into main Mar 4, 2022
@gitgauner gitgauner deleted the Implement_i18n branch March 4, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority Fix asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Localization with php-i18n and convert to json
2 participants