-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive Meta Panel #525
Responsive Meta Panel #525
Conversation
d3b336d
to
eb01573
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of having those, but I'm also not so happy with the proposed layout. I don't think that most people get that the # after the title is meant to be the permalink. And the arrow-out-of-the-box-icon is only used for external links, but not internal ones. So I think its odd that is now part of another internal link. |
@jeriox Agreed, but I am not sure I can do much about this at that point. Currently, all links not created by internal references get this arrow icon. I think this should be reworked in general in another branch |
eb01573
to
6c61056
Compare
53ccaaf
to
5922c00
Compare
Unfortunately, the used permanent link extension only allows to insert strings. The UTF 8 link emoji looks horrible on the latest windows 10, that's why we keep the |
Cannot reproduce the broken permalinks @frcroth |
43d6d42
to
be211c1
Compare
Co-authored-by: dropforge <151669220+dropforge@users.noreply.github.com>
8c39815
to
568cb4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poll pages still seem to have the old layout in the smartphone version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looking good!
Opened #587 for this
This varies depending on screen size, resolution and browser. This is probably not an issue introduced by this PR |
Opened #588 for this |
Closes #275, closes #329, closes #53
Replaces stale #285