Fix external link icons #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dropforge
force-pushed
the
external-link-icon
branch
from
5f13c7d
to
4481c33
Compare
This would allow attackers add a link to `//attack.com` and the browser interp
lukasrad02
approved these changes
Jul 29, 2024
dropforge
added a commit
to dropforge/myHPI
that referenced
this pull request
Jul 29, 2024
Closes fsr-de#583. Mitigates attack for links starting with // or /\ to spoof internal links (icon is not shown despite them being external). fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex only matched up to the first
<after the closing>of the<a>tag.Instead, everything up to the closing exact
</a>(except for newlines) is matched now (as few as possible.*?).The permalinks are no longer broken in #525 (cannot reproduce).
Closes #516