Improvements for Windows #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egabrum
commented
Oct 11, 2020
egabrum
commented
- Added parsing of net mask for Windows.
- Fixed default_interface for Windows
- Fixed test_command to make it compatible with both Linux and Windows.
add ifcfg.cli module, fix minor error in README
fix getting default interface in ubuntu 17.10
update travis & codecov badge url
Fix windows encoding error
Fixes encoding based on advice from @ftao
Fix for py2only syntax
It seems that if there are any docker network bridge interfaces present on Linux (Unix?) machine (tested on Ubuntu 17.10), it makes ifcfg crash while detecting devices due to the different naming pattern. As described here: https://github.com/docker/labs/blob/master/networking/concepts/05-bridge-networks.md docker creates network bridge interfaces with the following pattern, e.g.: `br-4bcc22f5e5b9`, which fails to match on any currently given regexp pattern. This commit simply adds hypen to the `UnixParser`, `get_patterns`'s first regexp pattern in order to catch interfaces with hypens as well. As far as the escaping of the hypen or its position within the pattern goes, my understanding is that the both cases are "safe" (having it as the first/last character in the group or escaping it with backlash). Here's an SO question/answer which realting a very similiar use case: https://stackoverflow.com/questions/9589074/regex-should-hyphens-be-escaped/9589642#9589642 This change also includes a test for this particular case.
…faces Handle detecting docker bridge interfaces
Bump to 0.15
- Adds support for capturing multiple IPv4 addresses via the 'inet4' field. The existing 'inet' field is preserved for backwards compatibility by simply grabbing the very first 'inet4' address found. (The previous behavior was to raise an exception.) - All existing 'inet' regex matching groups have been renamed to 'inet4'. - Added a new MacOSX unit test to validate this new 'inet4' output behavior. - Updated the README to show the new output field.
Created unit test based on sample data provided by user in issue ftao#20: "ifcfg does not see multiple ip addresses on one interfaces"
Feature: Multiple inet4 address for a single interface
- Bumped version to 0.16 - Added README.rst to the content of the python package (to appear on PyPI) - Fixed dead homepage link (now using current GitHub URL)
Minor packaging cleanups & Bump version 0.16
- Set the parser to UnixIPParser - Change ifconfig_cmd to a string since shell=True in Popen
force command to use C locale
Bump to 0.21
Bump also README
Add Python 3.7 to test matrix
Add Python 3.8 support to Travis config
Checking for `Default Gateway` that is `::` (IPv6 loopback) or in `127.0.0.0/8` (IPv4 loopback).
Added default interface detection for Windows.. addresses issue ftao#25
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
==========================================
+ Coverage 85.01% 85.13% +0.11%
==========================================
Files 4 4
Lines 267 269 +2
==========================================
+ Hits 227 229 +2
Misses 40 40
Continue to review full report at Codecov.
|
|
Somewhat related to issue #25 |
|
pinging @ftao |
|
pinging @benjaoming |
benjaoming
approved these changes
Oct 18, 2020
There was a problem hiding this comment.
Thanks @egabrum!
Since this is a small change similar to other patterns, I don't see the big risk. If you want to make sure it stays correct, you should add a test for it, though, in tests/ ipconfig_tests.py .
egabrum
force-pushed
the
fix-win-feature
branch
from
939d366 to
700a47d
Compare
|
Hi @egabrum - it seems you added the tests but something went wrong when rebasing the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.