Add musl build for aarch64 and armv7 binaries #713
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
| @@ -50,6 +50,15 @@ jobs: | |||
| - build: linux-arm | |||
| os: ubuntu-22.04 | |||
| target: aarch64-unknown-linux-gnu | |||
| - build: linux-arm | |||
There was a problem hiding this comment.
@patrickelectric I believe each build name has to be unique included in the matrix build list. I suggest renaming the Linux build jobs to include the architecture & gnu/musl information.
| target: aarch64-unknown-linux-musl | ||
| - build: linux-armv7 | ||
| os: ubuntu-22.04 | ||
| target: arm-unknown-linux-gnueabi |
There was a problem hiding this comment.
@patrickelectric there seem to be armv7 specific targets (https://doc.rust-lang.org/rustc/platform-support.html), should they be used here instead?
|
Thanks for the PR @patrickelectric ! I’ve added a couple of review comments. Once resolved i’d like to see this run on your fork to test it out (unfortunately we can’t test it here without doing an actual release!). The way to do that is to merge it to master on your fork and add a dummy release tag (1.2.3 is fine) to trigger the GitHub release workflow. |
|
ouch, at least the changes aren't lost |
|
Ouch I deleted the repository by mistake, I forgot about the PR! Will check it soon. |
1 similar comment
|
Ouch I deleted the repository by mistake, I forgot about the PR! Will check it soon. |
|
Yeah I suspected, at least github didn't delete all of your work. |
Fix #712
Signed-off-by: Patrick José Pereira patrickelectric@gmail.com